mirror of
https://github.com/antonioribeiro/google2fa.git
synced 2026-04-24 23:55:55 +03:00
[GH-ISSUE #227] Add argument and return type typehints #563
Labels
No labels
bug
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/google2fa#563
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @rimas-kudelis on GitHub (May 27, 2025).
Original GitHub issue: https://github.com/antonioribeiro/google2fa/issues/227
It's a bit weird to see the code using PHP attributes, but not documenting argument or return types, nor using strict types.
Would you consider adding these things and releasing a new major version?
@antonioribeiro commented on GitHub (May 27, 2025):
Have you seen the work being done here? https://github.com/antonioribeiro/google2fa/commits/9.x/
@rimas-kudelis commented on GitHub (May 28, 2025):
Not really. Your README says version 8 is still in beta, and this is version 9. 😆
If you've done that already, I'm glad and looking forward to a release!
@antonioribeiro commented on GitHub (May 28, 2025):
A lot of work to be done there still, but if you can help I can probably merge your PRs 😉