mirror of
https://github.com/antonioribeiro/google2fa.git
synced 2026-04-25 08:05:49 +03:00
[GH-ISSUE #192] Typo in a code of the Google2FA class on line 397 (8.x - php 7.4) #554
Labels
No labels
bug
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/google2fa#554
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @mozg3000 on GitHub (Dec 12, 2023).
Original GitHub issue: https://github.com/antonioribeiro/google2fa/issues/192
A comma at this line of a code crashes php script
github.com/antonioribeiro/google2fa@98c9e0544c/src/Google2FA.php (L396)because it is not allowed for php version < 8
@spaze commented on GitHub (Feb 29, 2024):
Thanks for the bug, after reading the report I've realized that the tests aren't actually using the selected PHP version and are always executed with the latest PHP version so the code with the trailing comma was never executed on PHP 7.x.
And the trailing comma was also introduced by me in #187, sorry.
The fix for both is in #196, hopefully it will be merged and released soon.
@spaze commented on GitHub (Sep 6, 2024):
Fixed in #211