mirror of
https://github.com/antonioribeiro/google2fa.git
synced 2026-04-25 16:15:49 +03:00
[GH-ISSUE #127] Compatibility problem with PHP < 7 #527
Labels
No labels
bug
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/google2fa#527
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @aletede21 on GitHub (Sep 23, 2019).
Original GitHub issue: https://github.com/antonioribeiro/google2fa/issues/127
In the file Base32.php row 75 there is a return type that is not provided in PHP < 7
@antonioribeiro commented on GitHub (Sep 23, 2019):
Yeah, it's hard to keep supporting older versions of PHP.
@antonioribeiro commented on GitHub (Sep 23, 2019):
New version should work on 7.0, removed those type hints, but I cannot rally test it on 7.0, because of: https://travis-ci.org/antonioribeiro/google2fa/jobs/588587454.
If you find a nice way to keep tests running on PHP<7.1, I can bring support back to it, but for now I will change it to PHP>=7.1.
@GrahamCampbell commented on GitHub (Apr 4, 2020):
This issue can be closed now.