mirror of
https://github.com/antonioribeiro/google2fa.git
synced 2026-04-24 23:55:55 +03:00
[GH-ISSUE #107] Google Infographics QR Code API is deprecated #51
Labels
No labels
bug
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/google2fa#51
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @bdteo on GitHub (Jul 23, 2018).
Original GitHub issue: https://github.com/antonioribeiro/google2fa/issues/107
See: https://developers.google.com/chart/infographics/docs/qr_codes
@antonioribeiro commented on GitHub (Oct 7, 2018):
Will check it, thank you!
@Chevil5 commented on GitHub (Mar 19, 2019):
Hi, is there any updates about that? 5 days ago Google turned off QR code generator api. And now it does not work at all.
@barryvdh commented on GitHub (Mar 19, 2019):
I can confirm that currently:
@antonioribeiro commented on GitHub (Mar 19, 2019):
Why Bacon doesn't work with it? When I removed it from this package to create the google2fa-bridge I tested it with both 1.x and 2.x...
@barryvdh commented on GitHub (Mar 19, 2019):
Oh sorry, I'm still on the 2.x branch.
I just saw your qr code package, but you don't mention it in the readme, right?
https://github.com/antonioribeiro/google2fa#qr-code-packages
An alternative would be to use http://goqr.me/api/ but I think it would probably best to not provide external API for this sensitive stuff.
@antonioribeiro commented on GitHub (Mar 19, 2019):
With Bacon 2.0:
Installing:
Using:
@barryvdh commented on GitHub (Mar 19, 2019):
Thanks, I've updated generate the QR with https://github.com/endroid/qr-code
But should we remove the Google API?
@antonioribeiro commented on GitHub (Mar 19, 2019):
Yeah, sorry, I wasn't really sure about "tying" one more package to this stack. But I will update the README and add some examples using it (mine), Bacon and Endroid.
@antonioribeiro commented on GitHub (Mar 19, 2019):
Yes, we must.
And thanks a lot for the Endroid fix!
@antonioribeiro commented on GitHub (Mar 19, 2019):
That Google API was deprecated in favor of https://developers.google.com/chart/, but I'm not sure there is a QRCode API inside it, will have to look better.
@antonioribeiro commented on GitHub (Mar 19, 2019):
@barryvdh, thanks for the PR.
Will try to add some more examples later.
@barryvdh commented on GitHub (Mar 19, 2019):
I don't think it supports QR code. So we can either:
@Chevil5 commented on GitHub (Mar 19, 2019):
-Silently replace with an data URL (eg. with bacon)
this option looks the most effective. The tool is very useful and it would be cruel just leave it unworking. Really people do not care how QR code generates, but only it should be secure, so to make in in-place by using Bacon would be perfect in my opinion.
@antonioribeiro commented on GitHub (Mar 19, 2019):
I was working on removing it for 5.0.0, already pushed some code to it, but looks like we will have to think this better.
I'm not found of adding Bacon or any other dependency back to this package, but if we do, to get a "fixed" version people would have to
composer update, so here's a question:Is there a way to make Composer warn people and tell them to upgrade to 5.0.0 and check the docs for options?
@Chevil5 commented on GitHub (Mar 19, 2019):
As far as I can see - no. And googling did not give any results.
But as a user, I can say it would be clear for me what is going on if on the first line of the documentation we will write: "Google API for QR generator is turned off. All version of that package less than 5.0.0 is deprecated and non-working. Please, make
composer updateand check documentation regarding new generation QR logic".In a few days, people will see that QR code is broken and will start googling or checking the documentation. And way they will find this information.
@barryvdh commented on GitHub (Mar 19, 2019):
An alternative would be to patch to previous version(s) to a hardcoded data url, with a message so it's more of a Soft fail.
@antonioribeiro commented on GitHub (Mar 19, 2019):
Done:
@antonioribeiro commented on GitHub (Mar 19, 2019):
What about this?:
As a warning when people
composer update?@antonioribeiro commented on GitHub (Mar 20, 2019):
It's done, but not working. Not sure why
https://github.com/Ocramius/PackageVersions/blob/master/composer.json
works, but this one doesn't:
https://github.com/antonioribeiro/google2fa/blob/v4.0.2/composer.json
@Chevil5 commented on GitHub (Mar 20, 2019):
@antonioribeiro thank you! Looks super noticeable and understandable! I also checked fixed documentation it looks very clear. I already fixed my code by your recommendations with Bacon and it works like a charm. So thank you for your work!
Warning in console looks also very good. But I'm not sure how to force it to work. It looks correct as far I can see.
@antonioribeiro commented on GitHub (Mar 20, 2019):
Opened an issue in Composer to try to understand and fix it: https://github.com/composer/composer/issues/8049
@hopeseekr commented on GitHub (Jul 14, 2019):
There is a way to immediately warn people... But it's not that good.
Then, any time anyone does
composer installorcomposer update, they'll get a big red warninggoogle2fa is abandoned: Use google-2fa instead..