[PR #232] Update PHPStan & Psalm to the latest versions #465

Open
opened 2026-03-01 17:49:47 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/antonioribeiro/google2fa/pull/232
Author: @spaze
Created: 11/23/2025
Status: 🔄 Open

Base: 10.xHead: spaze/update-phpstan-psalm


📝 Commits (5)

  • 546320b Allow Psalm 6, as 5 doesn't support PHP 8.4
  • 69de2d1 Add Override attributes to tests, as required by Psalm
  • e84a4e3 Simplify the timestamp calculation
  • 0503747 Use PHPStan 2.1.x
  • dfed67b Suppress ClassMustBeFinal everywhere in the code

📊 Changes

5 files changed (+9 additions, -4 deletions)

View changed files

📝 composer.json (+3 -3)
📝 psalm.xml (+1 -0)
📝 src/Google2FA.php (+1 -1)
📝 tests/Google2FATest.php (+2 -0)
📝 tests/QRCodeTest.php (+2 -0)

📄 Description

Also:

  • Added the final keyword to classes
  • Added Override attribute to tests
  • Simplified the timestamp calculation instead of typecasting the return values from microtime() or the $keyRegeneration property

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/antonioribeiro/google2fa/pull/232 **Author:** [@spaze](https://github.com/spaze) **Created:** 11/23/2025 **Status:** 🔄 Open **Base:** `10.x` ← **Head:** `spaze/update-phpstan-psalm` --- ### 📝 Commits (5) - [`546320b`](https://github.com/antonioribeiro/google2fa/commit/546320b9d00443fc452cd6f38750f9d1292e7386) Allow Psalm 6, as 5 doesn't support PHP 8.4 - [`69de2d1`](https://github.com/antonioribeiro/google2fa/commit/69de2d10fd627ef292f14d019c0947800ab1b427) Add Override attributes to tests, as required by Psalm - [`e84a4e3`](https://github.com/antonioribeiro/google2fa/commit/e84a4e3af87c60df730ad411565d4b3590903319) Simplify the timestamp calculation - [`0503747`](https://github.com/antonioribeiro/google2fa/commit/05037471f1770535734e9c9d0a1ecc0aa7213550) Use PHPStan 2.1.x - [`dfed67b`](https://github.com/antonioribeiro/google2fa/commit/dfed67ba6360ffb3e14e8b7abf81f30e564b1353) Suppress ClassMustBeFinal everywhere in the code ### 📊 Changes **5 files changed** (+9 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `composer.json` (+3 -3) 📝 `psalm.xml` (+1 -0) 📝 `src/Google2FA.php` (+1 -1) 📝 `tests/Google2FATest.php` (+2 -0) 📝 `tests/QRCodeTest.php` (+2 -0) </details> ### 📄 Description Also: - ~~Added the `final` keyword to classes~~ - Added `Override` attribute to tests - Simplified the timestamp calculation instead of typecasting the return values from `microtime()` or the `$keyRegeneration` property --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Sign in to join this conversation.
No labels
bug
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/google2fa#465
No description provided.