[PR #217] [MERGED] Psalm & PHPStan strict rules #456

New issue

Closed

opened 2026-03-01 17:49:44 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 17:49:44 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/antonioribeiro/google2fa/pull/217
Author: @spaze
Created: 10/13/2024
Status: ✅ Merged
Merged: 10/14/2024
Merged by: @antonioribeiro

Base: 9.x ← Head: spaze/psalm

📝 Commits (3)

08f3c23 Add phpstan/phpstan-strict-rules
bc49457 Fix strict rules errors
07a92b3 Analyze code with Psalm as well

📊 Changes

9 files changed (+132 additions, -103 deletions)

View changed files

📝 .github/workflows/run-tests.yml (+3 -0)
📝 composer.json (+3 -1)
📝 phpstan.neon (+1 -0)
➕ psalm.xml (+17 -0)
📝 src/Google2FA.php (+1 -1)
📝 src/Support/Base32.php (+1 -1)
📝 tests/Google2FATest.php (+97 -96)
📝 tests/QRCodeTest.php (+2 -1)
📝 tests/tools/analyse.sh (+7 -3)

📄 Description

Added Psalm and PHPStan strict rules.

Psalm: No errors on level 1 (the highest level for Psalm) and "Psalm was able to infer types for 100% of the codebase", not bad!

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/antonioribeiro/google2fa/pull/217 **Author:** [@spaze](https://github.com/spaze) **Created:** 10/13/2024 **Status:** ✅ Merged **Merged:** 10/14/2024 **Merged by:** [@antonioribeiro](https://github.com/antonioribeiro) **Base:** `9.x` ← **Head:** `spaze/psalm` --- ### 📝 Commits (3) - [`08f3c23`](https://github.com/antonioribeiro/google2fa/commit/08f3c230273ab40aad22c7d8776af9341a0f8d70) Add phpstan/phpstan-strict-rules - [`bc49457`](https://github.com/antonioribeiro/google2fa/commit/bc4945797c39c1c057de3137010f36063bd48b32) Fix strict rules errors - [`07a92b3`](https://github.com/antonioribeiro/google2fa/commit/07a92b30cba0602453971bc59246c82c8d1eaa53) Analyze code with Psalm as well ### 📊 Changes **9 files changed** (+132 additions, -103 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/run-tests.yml` (+3 -0) 📝 `composer.json` (+3 -1) 📝 `phpstan.neon` (+1 -0) ➕ `psalm.xml` (+17 -0) 📝 `src/Google2FA.php` (+1 -1) 📝 `src/Support/Base32.php` (+1 -1) 📝 `tests/Google2FATest.php` (+97 -96) 📝 `tests/QRCodeTest.php` (+2 -1) 📝 `tests/tools/analyse.sh` (+7 -3) </details> ### 📄 Description Added Psalm and PHPStan strict rules. Psalm: No errors on level 1 (the highest level for Psalm) and "Psalm was able to infer types for 100% of the codebase", not bad! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 17:49:44 +03:00

closed this issue
added the
pull-request
label

No labels

bug

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/google2fa#456

No description provided.

Rows
Columns