[PR #216] [CLOSED] feat: fixed style, return type declaration type hinting add #452

New issue

Closed

opened 2026-03-01 17:49:44 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 17:49:44 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/antonioribeiro/google2fa/pull/216
Author: @eramitgupta
Created: 10/12/2024
Status: ❌ Closed

Base: 8.x ← Head: 8.x

📝 Commits (1)

0e0403c feat: fixed style, return type declaration type hinting add

📊 Changes

12 files changed (+168 additions, -306 deletions)

View changed files

📝 src/Exceptions/Contracts/Google2FA.php (+1 -3)
📝 src/Exceptions/Contracts/IncompatibleWithGoogleAuthenticator.php (+1 -3)
📝 src/Exceptions/Contracts/InvalidAlgorithm.php (+1 -3)
📝 src/Exceptions/Contracts/InvalidCharacters.php (+1 -3)
📝 src/Exceptions/Contracts/SecretKeyTooShort.php (+1 -3)
📝 src/Exceptions/Google2FAException.php (+1 -3)
📝 src/Google2FA.php (+105 -197)
📝 src/Support/Base32.php (+48 -77)
📝 src/Support/QRCode.php (+5 -10)
📝 tests/Google2FATest.php (+1 -1)
📝 tests/QRCodeTest.php (+1 -1)
📝 tests/helpers.php (+2 -2)

📄 Description

feat: Fix styles and add return type declaration hinting

Improved the styling of the components for consistency and responsiveness.
Added return type declaration type hinting for better code readability and to enhance static analysis.
Ensured that type hinting is used across relevant methods for improved maintainability and debugging.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/antonioribeiro/google2fa/pull/216 **Author:** [@eramitgupta](https://github.com/eramitgupta) **Created:** 10/12/2024 **Status:** ❌ Closed **Base:** `8.x` ← **Head:** `8.x` --- ### 📝 Commits (1) - [`0e0403c`](https://github.com/antonioribeiro/google2fa/commit/0e0403c17d3262b0b764d2c1087d5feb0bae24ae) feat: fixed style, return type declaration type hinting add ### 📊 Changes **12 files changed** (+168 additions, -306 deletions) <details> <summary>View changed files</summary> 📝 `src/Exceptions/Contracts/Google2FA.php` (+1 -3) 📝 `src/Exceptions/Contracts/IncompatibleWithGoogleAuthenticator.php` (+1 -3) 📝 `src/Exceptions/Contracts/InvalidAlgorithm.php` (+1 -3) 📝 `src/Exceptions/Contracts/InvalidCharacters.php` (+1 -3) 📝 `src/Exceptions/Contracts/SecretKeyTooShort.php` (+1 -3) 📝 `src/Exceptions/Google2FAException.php` (+1 -3) 📝 `src/Google2FA.php` (+105 -197) 📝 `src/Support/Base32.php` (+48 -77) 📝 `src/Support/QRCode.php` (+5 -10) 📝 `tests/Google2FATest.php` (+1 -1) 📝 `tests/QRCodeTest.php` (+1 -1) 📝 `tests/helpers.php` (+2 -2) </details> ### 📄 Description **feat: Fix styles and add return type declaration hinting** - Improved the styling of the components for consistency and responsiveness. - Added return type declaration type hinting for better code readability and to enhance static analysis. - Ensured that type hinting is used across relevant methods for improved maintainability and debugging. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 17:49:44 +03:00

closed this issue
added the
pull-request
label

No labels

bug

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/google2fa#452

No description provided.

Rows
Columns