mirror of
https://github.com/antonioribeiro/google2fa.git
synced 2026-04-25 16:15:49 +03:00
[PR #195] [MERGED] The default validation window is 1, not 4 #432
Labels
No labels
bug
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/google2fa#432
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/antonioribeiro/google2fa/pull/195
Author: @spaze
Created: 2/29/2024
Status: ✅ Merged
Merged: 10/13/2024
Merged by: @antonioribeiro
Base:
8.x← Head:spaze/default-window📝 Commits (2)
65e87f4The default validation window is 1, not 496d7d9eDescribe the $window parameter in a bit more details📊 Changes
2 files changed (+8 additions, -1 deletions)
View changed files
📝
README.md(+3 -1)📝
tests/Google2FATest.php(+5 -0)📄 Description
Also describe the
$windowparameter in a bit more details .Note that the TOTP RFC also recommends extending the validation window so I think a bit more details may help the reader to understand what's that for.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.