[PR #88] [CLOSED] Use PHPUnit\Framework\TestCase instead of PHPUnit_Framework_TestCase #385

New issue

Closed

opened 2026-03-01 17:49:28 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 17:49:28 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/antonioribeiro/google2fa/pull/88
Author: @carusogabriel
Created: 11/11/2017
Status: ❌ Closed

Base: master ← Head: phpunit

📝 Commits (1)

1050ef7 Use PHPUnit\Framework\TestCase instead of PHPUnit_Framework_TestCase

📊 Changes

2 files changed (+3 additions, -2 deletions)

View changed files

📝 composer.json (+1 -1)
📝 tests/Google2FATest.php (+2 -1)

📄 Description

I use the PHPUnit\Framework\TestCase notation instead of PHPUnit_Framework_TestCase while extending our TestCase. This will help us migrate to PHPUnit 6, that no longer support snake case class names.

I just need to bump PHPUnit version to ^4.8.35, that support this namespace.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/antonioribeiro/google2fa/pull/88 **Author:** [@carusogabriel](https://github.com/carusogabriel) **Created:** 11/11/2017 **Status:** ❌ Closed **Base:** `master` ← **Head:** `phpunit` --- ### 📝 Commits (1) - [`1050ef7`](https://github.com/antonioribeiro/google2fa/commit/1050ef7ae1ee471d078d2417e6240dfb6e560e35) Use PHPUnit\Framework\TestCase instead of PHPUnit_Framework_TestCase ### 📊 Changes **2 files changed** (+3 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `composer.json` (+1 -1) 📝 `tests/Google2FATest.php` (+2 -1) </details> ### 📄 Description I use the `PHPUnit\Framework\TestCase` notation instead of `PHPUnit_Framework_TestCase` while extending our TestCase. This will help us migrate to PHPUnit 6, that [no longer support snake case class names](https://github.com/sebastianbergmann/phpunit/blob/master/ChangeLog-6.0.md#changed-1). I just need to bump PHPUnit version to [`^4.8.35`](https://github.com/sebastianbergmann/phpunit/blob/master/ChangeLog-4.8.md#4835---2017-02-06), that support this namespace. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 17:49:28 +03:00

closed this issue
added the
pull-request
label

No labels

bug

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/google2fa#385

No description provided.

Rows
Columns