mirror of
https://github.com/antonioribeiro/google2fa.git
synced 2026-04-26 00:25:52 +03:00
[PR #21] [MERGED] Add '$encoding' parameter to getQRCodeInline() to avoid CJK issues. #344
Labels
No labels
bug
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/google2fa#344
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/antonioribeiro/google2fa/pull/21
Author: @zhiyi7
Created: 12/18/2015
Status: ✅ Merged
Merged: 5/9/2016
Merged by: @antonioribeiro
Base:
master← Head:master📝 Commits (1)
6e8c7b4Add '$encoding' parameter to getQRCodeInline() to avoid CJK issues.📊 Changes
1 file changed (+6 additions, -1 deletions)
View changed files
📝
src/Google2FA.php(+6 -1)📄 Description
If $company or $holder includes CJK(or any UTF8) character, the default encoding ISO8859-1 which used in BaconQrCodeGenerator will cause an error while it generating QR code.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.