[GH-ISSUE #26] Drop "Str" class in favor of "symfony/polyfill-php56" package #249

New issue

Closed

opened 2026-03-01 17:48:37 +03:00 by kerem · 2 comments

kerem commented

2026-03-01 17:48:37 +03:00

Owner

Originally created by @aik099 on GitHub (Mar 11, 2016).
Original GitHub issue: https://github.com/antonioribeiro/google2fa/issues/26

The https://packagist.org/packages/symfony/polyfill-php56 package provides hash_equals function (when it's missing only) and therefore:

the hash_equals(...) can be used instead of Str::equals(...)
the whole Str class can be dropped, because it's only consists of that equals function

Originally created by @aik099 on GitHub (Mar 11, 2016). Original GitHub issue: https://github.com/antonioribeiro/google2fa/issues/26 The https://packagist.org/packages/symfony/polyfill-php56 package provides `hash_equals` function (when it's missing only) and therefore: - the `hash_equals(...)` can be used instead of `Str::equals(...)` - the whole `Str` class can be dropped, because it's only consists of that `equals` function

kerem closed this issue

2026-03-01 17:48:37 +03:00

kerem commented

2026-03-01 17:48:38 +03:00

Author

Owner

@base-zero commented on GitHub (May 9, 2016):

👍

@base-zero commented on GitHub (May 9, 2016): 👍

kerem commented

2026-03-01 17:48:38 +03:00

Author

Owner

@aik099 commented on GitHub (Jun 17, 2016):

PR created, ready for review.

@aik099 commented on GitHub (Jun 17, 2016): PR created, ready for review.

No labels

bug

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/google2fa#249

No description provided.

Rows
Columns