mirror of
https://github.com/antonioribeiro/google2fa.git
synced 2026-04-26 08:35:54 +03:00
[GH-ISSUE #55] Company name & Holder name with spaces #24
Labels
No labels
bug
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/google2fa#24
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @david-vde on GitHub (Dec 2, 2016).
Original GitHub issue: https://github.com/antonioribeiro/google2fa/issues/55
Hi have a bug when using spaces in company name or holder.
I seen that this issue is fixed but not yet released.
After analysing your fix, I can see that you made a rawurlencode on company but not holder name. Why is that? The holder name can also have spaces.
See: https://github.com/antonioribeiro/google2fa/blob/master/src/Google2FA.php#L311
Thanks
@antonioribeiro commented on GitHub (Jun 17, 2017):
Will be present in the next version.