[PR #195] [MERGED] The default validation window is 1, not 4 #202

New issue

Closed

opened 2026-02-25 20:32:49 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 20:32:49 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/antonioribeiro/google2fa/pull/195
Author: @spaze
Created: 2/29/2024
Status: ✅ Merged
Merged: 10/13/2024
Merged by: @antonioribeiro

Base: 8.x ← Head: spaze/default-window

📝 Commits (2)

65e87f4 The default validation window is 1, not 4
96d7d9e Describe the $window parameter in a bit more details

📊 Changes

2 files changed (+8 additions, -1 deletions)

View changed files

📝 README.md (+3 -1)
📝 tests/Google2FATest.php (+5 -0)

📄 Description

Also describe the $window parameter in a bit more details .

Note that the TOTP RFC also recommends extending the validation window so I think a bit more details may help the reader to understand what's that for.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/antonioribeiro/google2fa/pull/195 **Author:** [@spaze](https://github.com/spaze) **Created:** 2/29/2024 **Status:** ✅ Merged **Merged:** 10/13/2024 **Merged by:** [@antonioribeiro](https://github.com/antonioribeiro) **Base:** `8.x` ← **Head:** `spaze/default-window` --- ### 📝 Commits (2) - [`65e87f4`](https://github.com/antonioribeiro/google2fa/commit/65e87f457a5ff0849d783d1ad9b541c32bb185de) The default validation window is 1, not 4 - [`96d7d9e`](https://github.com/antonioribeiro/google2fa/commit/96d7d9e7533be1def04460e980036a1962662644) Describe the $window parameter in a bit more details ### 📊 Changes **2 files changed** (+8 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+3 -1) 📝 `tests/Google2FATest.php` (+5 -0) </details> ### 📄 Description Also describe the `$window` parameter in a bit more details . Note that the TOTP RFC also [recommends](https://datatracker.ietf.org/doc/html/rfc6238#section-6) extending the validation window so I think a bit more details may help the reader to understand what's that for. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>