[PR #122] [MERGED] Removed legacy PHPUnit configuration #163

Closed
opened 2026-02-25 20:32:39 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/antonioribeiro/google2fa/pull/122
Author: @poisa
Created: 6/23/2019
Status: Merged
Merged: 9/11/2019
Merged by: @antonioribeiro

Base: masterHead: removed-legacy-phpunit-config


📝 Commits (1)

  • 55cac62 Removed legacy PHPUnit configuration

📊 Changes

1 file changed (+0 additions, -1 deletions)

View changed files

📝 phpunit.xml (+0 -1)

📄 Description

When running the test suites I was getting the following error:

  Warning - The configuration file did not pass validation!
  The following problems have been detected:

  Line 15:
  - Element 'phpunit', attribute 'syntaxCheck': The attribute 'syntaxCheck' is not allowed.

  Test results may not be as expected.

According to the PHPUnit's author (https://stackoverflow.com/a/44331140/255260

That configuration setting has not had an effect in years. It was removed long ago.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/antonioribeiro/google2fa/pull/122 **Author:** [@poisa](https://github.com/poisa) **Created:** 6/23/2019 **Status:** ✅ Merged **Merged:** 9/11/2019 **Merged by:** [@antonioribeiro](https://github.com/antonioribeiro) **Base:** `master` ← **Head:** `removed-legacy-phpunit-config` --- ### 📝 Commits (1) - [`55cac62`](https://github.com/antonioribeiro/google2fa/commit/55cac6252a54a121da00fe06ea31b29ef715b03e) Removed legacy PHPUnit configuration ### 📊 Changes **1 file changed** (+0 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `phpunit.xml` (+0 -1) </details> ### 📄 Description When running the test suites I was getting the following error: ``` Warning - The configuration file did not pass validation! The following problems have been detected: Line 15: - Element 'phpunit', attribute 'syntaxCheck': The attribute 'syntaxCheck' is not allowed. Test results may not be as expected. ``` According to the PHPUnit's author (https://stackoverflow.com/a/44331140/255260 >That configuration setting has not had an effect in years. It was removed long ago. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-25 20:32:39 +03:00
Sign in to join this conversation.
No labels
bug
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/google2fa#163
No description provided.