[PR #104] [CLOSED] Support bacon-qr-code 2.0.0 #155

New issue

Closed

opened 2026-02-25 20:32:38 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 20:32:38 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/antonioribeiro/google2fa/pull/104
Author: @asbiin
Created: 5/2/2018
Status: ❌ Closed

Base: master ← Head: bacon-qr-code-2.0.0

📝 Commits (2)

08963a2 Support bacon-qr-code 2.0.0
22ef2b9 Fix StyleCI

📊 Changes

1 file changed (+28 additions, -4 deletions)

View changed files

📝 src/Support/QRCode.php (+28 -4)

📄 Description

Add support of bacon-qr-code v2.0.0

Class Png does not exist anymore.
We have to use ImagickImageBackEnd instead - which require imagick php extension.

I've also added the support of svg image, by adding a new parameter to getQRCodeInline.

PS: the test on line https://github.com/antonioribeiro/google2fa/blob/master/tests/Google2FATest.php#L220 does not work on my computer: I hav php 7.1, and I get QRCODEPHPABOVE72 result...

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/antonioribeiro/google2fa/pull/104 **Author:** [@asbiin](https://github.com/asbiin) **Created:** 5/2/2018 **Status:** ❌ Closed **Base:** `master` ← **Head:** `bacon-qr-code-2.0.0` --- ### 📝 Commits (2) - [`08963a2`](https://github.com/antonioribeiro/google2fa/commit/08963a282439a240259990371c6aa771d5c221ba) Support bacon-qr-code 2.0.0 - [`22ef2b9`](https://github.com/antonioribeiro/google2fa/commit/22ef2b9d74d33adcba5e14eaae14947b1e256005) Fix StyleCI ### 📊 Changes **1 file changed** (+28 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/Support/QRCode.php` (+28 -4) </details> ### 📄 Description Add support of bacon-qr-code v2.0.0 Class Png does not exist anymore. We have to use `ImagickImageBackEnd` instead - which require imagick php extension. I've also added the support of svg image, by adding a new parameter to `getQRCodeInline`. PS: the test on line https://github.com/antonioribeiro/google2fa/blob/master/tests/Google2FATest.php#L220 does not work on my computer: I hav php 7.1, and I get QRCODEPHPABOVE72 result... --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>