[PR #36] [MERGED] Use base QR code package, update contract methods #119

New issue

Closed

opened 2026-02-25 20:32:32 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 20:32:32 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/antonioribeiro/google2fa/pull/36
Author: @barryvdh
Created: 7/15/2016
Status: ✅ Merged
Merged: 7/17/2016
Merged by: @antonioribeiro

Base: master ← Head: patch-3

📝 Commits (4)

6327af9 Update inline image generator
a74b5ae Require bacon/bacon-qr-code instead of wrapper
30501e1 Add inline function to contract
4af2c78 Use default margin

📊 Changes

3 files changed (+40 additions, -24 deletions)

View changed files

📝 composer.json (+1 -1)
📝 src/Contracts/Google2FA.php (+17 -4)
📝 src/Google2FA.php (+22 -19)

📄 Description

Use base package instead of wrapper for QR code (less dependencies, now requires on laravel support)
Update default size to 200, don't set 0 margin, same as Google
Add size parameter to Google URL, to match inline (default 200)
Add inline function to contract.

Note: As the interface changes, this is a breaking change and should be tagged as a new minor version, 0.8.0 currently,

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/antonioribeiro/google2fa/pull/36 **Author:** [@barryvdh](https://github.com/barryvdh) **Created:** 7/15/2016 **Status:** ✅ Merged **Merged:** 7/17/2016 **Merged by:** [@antonioribeiro](https://github.com/antonioribeiro) **Base:** `master` ← **Head:** `patch-3` --- ### 📝 Commits (4) - [`6327af9`](https://github.com/antonioribeiro/google2fa/commit/6327af99426393765c6a3aff4ee25f316cead1d8) Update inline image generator - [`a74b5ae`](https://github.com/antonioribeiro/google2fa/commit/a74b5ae9e75155b95e5e4f55176d21a4e3f0feb1) Require bacon/bacon-qr-code instead of wrapper - [`30501e1`](https://github.com/antonioribeiro/google2fa/commit/30501e14e36b42edeb6be9114aa204ac676749e9) Add inline function to contract - [`4af2c78`](https://github.com/antonioribeiro/google2fa/commit/4af2c780c9a6a3945417f32dac1bee8e53b834d9) Use default margin ### 📊 Changes **3 files changed** (+40 additions, -24 deletions) <details> <summary>View changed files</summary> 📝 `composer.json` (+1 -1) 📝 `src/Contracts/Google2FA.php` (+17 -4) 📝 `src/Google2FA.php` (+22 -19) </details> ### 📄 Description - Use base package instead of wrapper for QR code (less dependencies, now requires on laravel support) - Update default size to 200, don't set 0 margin, same as Google - Add size parameter to Google URL, to match inline (default 200) - Add inline function to contract. Note: As the interface changes, this is a breaking change and should be tagged as a new minor version, 0.8.0 currently, --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>