[PR #21] [MERGED] Add '$encoding' parameter to getQRCodeInline() to avoid CJK issues. #109

New issue

Closed

opened 2026-02-25 20:32:30 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 20:32:30 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/antonioribeiro/google2fa/pull/21
Author: @zhiyi7
Created: 12/18/2015
Status: ✅ Merged
Merged: 5/9/2016
Merged by: @antonioribeiro

Base: master ← Head: master

📝 Commits (1)

6e8c7b4 Add '$encoding' parameter to getQRCodeInline() to avoid CJK issues.

📊 Changes

1 file changed (+6 additions, -1 deletions)

View changed files

📝 src/Google2FA.php (+6 -1)

📄 Description

If $company or $holder includes CJK(or any UTF8) character, the default encoding ISO8859-1 which used in BaconQrCodeGenerator will cause an error while it generating QR code.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/antonioribeiro/google2fa/pull/21 **Author:** [@zhiyi7](https://github.com/zhiyi7) **Created:** 12/18/2015 **Status:** ✅ Merged **Merged:** 5/9/2016 **Merged by:** [@antonioribeiro](https://github.com/antonioribeiro) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`6e8c7b4`](https://github.com/antonioribeiro/google2fa/commit/6e8c7b46d42ebbf0ed116379e6f48234ebd169e4) Add '$encoding' parameter to getQRCodeInline() to avoid CJK issues. ### 📊 Changes **1 file changed** (+6 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/Google2FA.php` (+6 -1) </details> ### 📄 Description If $company or $holder includes CJK(or any UTF8) character, the default encoding ISO8859-1 which used in BaconQrCodeGenerator will cause an error while it generating QR code. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>