[PR #5] [MERGED] Code clean #100

New issue

Closed

opened 2026-02-25 20:32:28 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 20:32:28 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/antonioribeiro/google2fa/pull/5
Author: @jbrooksuk
Created: 1/9/2015
Status: ✅ Merged
Merged: 1/9/2015
Merged by: @antonioribeiro

Base: master ← Head: code-clean

📝 Commits (2)

3881c93 Remove .idea/ folder
577a02b Code clean up. Use PSR-2.

📊 Changes

15 files changed (+1209 additions, -253 deletions)

View changed files

📝 .gitignore (+1 -2)
➖ .idea/.name (+0 -1)
➖ .idea/encodings.xml (+0 -5)
➖ .idea/google2fa.iml (+0 -9)
➖ .idea/misc.xml (+0 -5)
➖ .idea/modules.xml (+0 -9)
➖ .idea/scopes/scope_settings.xml (+0 -5)
➖ .idea/vcs.xml (+0 -7)
➖ .idea/workspace.xml (+0 -186)
📝 composer.json (+1 -9)
➕ composer.lock (+1189 -0)
📝 src/Exceptions/InvalidCharactersException.php (+3 -2)
📝 src/Exceptions/SecretKeyTooShortException.php (+3 -2)
📝 src/Google2FA.php (+8 -7)
📝 src/Vendor/Laravel/ServiceProvider.php (+4 -4)

📄 Description

Remove .idea/ folder this should be in your global .gitignore file.
Trailing lines have been striped.
Should all be PSR-2.
composer.lock should be committed for a package.
phpunit is required for dev?

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/antonioribeiro/google2fa/pull/5 **Author:** [@jbrooksuk](https://github.com/jbrooksuk) **Created:** 1/9/2015 **Status:** ✅ Merged **Merged:** 1/9/2015 **Merged by:** [@antonioribeiro](https://github.com/antonioribeiro) **Base:** `master` ← **Head:** `code-clean` --- ### 📝 Commits (2) - [`3881c93`](https://github.com/antonioribeiro/google2fa/commit/3881c93ee0c709d8b8c6a689b377937bad1935c4) Remove .idea/ folder - [`577a02b`](https://github.com/antonioribeiro/google2fa/commit/577a02ba2851b2569a665287f84c331c990df136) Code clean up. Use PSR-2. ### 📊 Changes **15 files changed** (+1209 additions, -253 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+1 -2) ➖ `.idea/.name` (+0 -1) ➖ `.idea/encodings.xml` (+0 -5) ➖ `.idea/google2fa.iml` (+0 -9) ➖ `.idea/misc.xml` (+0 -5) ➖ `.idea/modules.xml` (+0 -9) ➖ `.idea/scopes/scope_settings.xml` (+0 -5) ➖ `.idea/vcs.xml` (+0 -7) ➖ `.idea/workspace.xml` (+0 -186) 📝 `composer.json` (+1 -9) ➕ `composer.lock` (+1189 -0) 📝 `src/Exceptions/InvalidCharactersException.php` (+3 -2) 📝 `src/Exceptions/SecretKeyTooShortException.php` (+3 -2) 📝 `src/Google2FA.php` (+8 -7) 📝 `src/Vendor/Laravel/ServiceProvider.php` (+4 -4) </details> ### 📄 Description - Remove `.idea/` folder this should be in your global `.gitignore` file. - Trailing lines have been striped. - Should all be PSR-2. - `composer.lock` should be committed for a package. - `phpunit` is required for dev? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>