[PR #40] [MERGED] feat: added WithSkipValidDIrectivesErr option #55

New issue

Closed

opened 2026-02-28 01:20:43 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 01:20:43 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/tufanbarisyildirim/gonginx/pull/40
Author: @0xJacky
Created: 1/16/2024
Status: ✅ Merged
Merged: 1/19/2024
Merged by: @tufanbarisyildirim

Base: master ← Head: master

📝 Commits (1)

c0d7695 feat: added WithSkipValidDIrectivesErr option

📊 Changes

1 file changed (+18 additions, -8 deletions)

View changed files

📝 parser/parser.go (+18 -8)

📄 Description

When parsing the following content in gonginx v2, it will throw a error: unknown directive '''' on line 3, column 5.

map $http_upgrade $connection_upgrade {
        default upgrade;
        ''      close;
}

However, this configuration is provided by https://nginx.org/en/docs/http/websocket.html.

I think we can add a WithSkipValidDIrectivesErr option to skip the directives validation check.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/tufanbarisyildirim/gonginx/pull/40 **Author:** [@0xJacky](https://github.com/0xJacky) **Created:** 1/16/2024 **Status:** ✅ Merged **Merged:** 1/19/2024 **Merged by:** [@tufanbarisyildirim](https://github.com/tufanbarisyildirim) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`c0d7695`](https://github.com/tufanbarisyildirim/gonginx/commit/c0d76957d0c72decb08e227bc4a60992503d0c89) feat: added WithSkipValidDIrectivesErr option ### 📊 Changes **1 file changed** (+18 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `parser/parser.go` (+18 -8) </details> ### 📄 Description When parsing the following content in gonginx v2, it will throw a error: unknown directive '''' on line 3, column 5. ``` map $http_upgrade $connection_upgrade { default upgrade; '' close; } ``` However, this configuration is provided by https://nginx.org/en/docs/http/websocket.html. I think we can add a WithSkipValidDIrectivesErr option to skip the directives validation check. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>