[GH-ISSUE #3] unquote parameters #2

New issue

Closed

opened 2026-02-28 01:20:27 +03:00 by kerem · 2 comments

kerem commented

2026-02-28 01:20:27 +03:00

Owner

Originally created by @virusdefender on GitHub (Jul 15, 2020).
Original GitHub issue: https://github.com/tufanbarisyildirim/gonginx/issues/3

for example load_module "modules/ngx_stream_module.so";

we will get a quoted string now

{
        "Block": null,
        "Name": "load_module",
        "Parameters": [
            "\"modules/ngx_stream_module.so\""
        ]
}

Originally created by @virusdefender on GitHub (Jul 15, 2020). Original GitHub issue: https://github.com/tufanbarisyildirim/gonginx/issues/3 for example `load_module "modules/ngx_stream_module.so";` we will get a quoted string now ``` { "Block": null, "Name": "load_module", "Parameters": [ "\"modules/ngx_stream_module.so\"" ] } ```

kerem closed this issue

2026-02-28 01:20:27 +03:00

kerem commented

2026-02-28 01:20:28 +03:00

Author

Owner

@tufanbarisyildirim commented on GitHub (Dec 20, 2020):

@virusdefender thanks for reporting. You can trim it before using. This needs some more developements to keep parameters with sth like quoted flag. Because those are needed to be quoted on dumping. I will think on it to find an easy way without a gib refactor but I would like to keep as is. (if you have any advice, do not hesitate to open a PR)

@tufanbarisyildirim commented on GitHub (Dec 20, 2020): @virusdefender thanks for reporting. You can trim it before using. This needs some more developements to keep parameters with sth like `quoted` flag. Because those are needed to be quoted on dumping. I will think on it to find an easy way without a gib refactor but I would like to keep as is. (if you have any advice, do not hesitate to open a PR)

kerem commented

2026-02-28 01:20:28 +03:00

Author

Owner

@tufanbarisyildirim commented on GitHub (Jul 15, 2021):

closing this, I think unfolding should not be a part of parsing.

@tufanbarisyildirim commented on GitHub (Jul 15, 2021): closing this, I think unfolding should not be a part of parsing.