[PR #42] [MERGED] Extend VM config to cover most documented fields #98

New issue

Closed

opened 2026-03-03 15:30:11 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 15:30:11 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/luthermonson/go-proxmox/pull/42
Author: @jqueuniet
Created: 1/13/2023
Status: ✅ Merged
Merged: 1/13/2023
Merged by: @luthermonson

Base: main ← Head: extend_vm_config

📝 Commits (6)

bc6e065 Extend VirtualMachineConfig to cover most of the config GET spec endpoint
d076f4c Fix VirtIO naming consistency
f6cf5ed Remove old debug comments
5478e43 Factor the device merge functions in a helper, remove regexps
e6fb33e Fix typo
040a95d Merge branch 'main' into extend_vm_config

📊 Changes

1 file changed (+299 additions, -168 deletions)

View changed files

📝 types.go (+299 -168)

📄 Description

I was missing a few fields for my own use, and figured it would be nice to extend this VirtualMachineConfig a bit further since I may need the rest later on anyway. Now I know this is a lot of fields, but even parallel ports have their use sometimes (though I hope I'll never have to go down this path myself).

I actually cut a few superfluous ones on the way. The endpoint spec seems to indicates IDE devices are limited to 4 and SATA to 6. SCSI on the other hand goes as far as 30. I let lists with unspecified limits at 10 as this seemed a reasonable default

The diff is a bit of a mess since I figured a struct as large as this warranted some reorganization rather than an endless unsorted list. I also added JSON tags everywhere and replaced the regexp compilations to do away with the init().

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/luthermonson/go-proxmox/pull/42 **Author:** [@jqueuniet](https://github.com/jqueuniet) **Created:** 1/13/2023 **Status:** ✅ Merged **Merged:** 1/13/2023 **Merged by:** [@luthermonson](https://github.com/luthermonson) **Base:** `main` ← **Head:** `extend_vm_config` --- ### 📝 Commits (6) - [`bc6e065`](https://github.com/luthermonson/go-proxmox/commit/bc6e065248d4176c54af2533bb7d2084c169e6a3) Extend VirtualMachineConfig to cover most of the config GET spec endpoint - [`d076f4c`](https://github.com/luthermonson/go-proxmox/commit/d076f4c17b1446e0dfeeaf49e41d8aa2eddb1078) Fix VirtIO naming consistency - [`f6cf5ed`](https://github.com/luthermonson/go-proxmox/commit/f6cf5edb415497bab724613559c3a12fe16798be) Remove old debug comments - [`5478e43`](https://github.com/luthermonson/go-proxmox/commit/5478e4306f7a59aca197bb27789de561b5c7b2c6) Factor the device merge functions in a helper, remove regexps - [`e6fb33e`](https://github.com/luthermonson/go-proxmox/commit/e6fb33eb0741430626823200df5d8fe2f83eff3d) Fix typo - [`040a95d`](https://github.com/luthermonson/go-proxmox/commit/040a95df41c275285803d6f31e81b11d22c53e1d) Merge branch 'main' into extend_vm_config ### 📊 Changes **1 file changed** (+299 additions, -168 deletions) <details> <summary>View changed files</summary> 📝 `types.go` (+299 -168) </details> ### 📄 Description I was missing a few fields for my own use, and figured it would be nice to extend this `VirtualMachineConfig` a bit further since I may need the rest later on anyway. Now I know this is a lot of fields, but even parallel ports have their use sometimes (though I hope I'll never have to go down this path myself). I actually cut a few superfluous ones on the way. The endpoint spec seems to indicates IDE devices are limited to 4 and SATA to 6. SCSI on the other hand goes as far as 30. I let lists with unspecified limits at 10 as this seemed a reasonable default The diff is a bit of a mess since I figured a struct as large as this warranted some reorganization rather than an endless unsorted list. I also added JSON tags everywhere and replaced the regexp compilations to do away with the init(). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>