[GH-ISSUE #128] Convert Old Container Funcs to use UPID/Tasks #27

Closed
opened 2026-03-03 15:29:41 +03:00 by kerem · 2 comments
Owner

Originally created by @luthermonson on GitHub (Mar 7, 2024).
Original GitHub issue: https://github.com/luthermonson/go-proxmox/issues/128

The first Container funcs were created before UPID/Tasks were done so it used a ContainerStatus struct, this was changed to a string now but should ultimately be the UPID/Task system with a func profile looking similar to this...

func (c *Container) Start(ctx context.Context) (task *Task, err error)
func (c *Container) Stop(ctx context.Context) (task *Task, err error)
func (c *Container) Suspend(ctx context.Context) (task *Task, err error)
func (c *Container) Reboot(ctx context.Context) (task *Task, err error)
func (c *Container) Resume(ctx context.Context) (task *Task, err error)
func (c *Container) Shutdown(ctx context.Context, force bool, timeout int) (task *Task, err error)
Originally created by @luthermonson on GitHub (Mar 7, 2024). Original GitHub issue: https://github.com/luthermonson/go-proxmox/issues/128 The first Container funcs were created before UPID/Tasks were done so it used a ContainerStatus struct, this was changed to a string now but should ultimately be the UPID/Task system with a func profile looking similar to this... ``` func (c *Container) Start(ctx context.Context) (task *Task, err error) func (c *Container) Stop(ctx context.Context) (task *Task, err error) func (c *Container) Suspend(ctx context.Context) (task *Task, err error) func (c *Container) Reboot(ctx context.Context) (task *Task, err error) func (c *Container) Resume(ctx context.Context) (task *Task, err error) func (c *Container) Shutdown(ctx context.Context, force bool, timeout int) (task *Task, err error) ```
kerem closed this issue 2026-03-03 15:29:42 +03:00
Author
Owner

@luthermonson commented on GitHub (Mar 7, 2024):

@alperencelik for visibility

<!-- gh-comment-id:1983869699 --> @luthermonson commented on GitHub (Mar 7, 2024): @alperencelik for visibility
Author
Owner

@luthermonson commented on GitHub (Mar 7, 2024):

fixed by #129

<!-- gh-comment-id:1984527484 --> @luthermonson commented on GitHub (Mar 7, 2024): fixed by #129
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/go-proxmox#27
No description provided.