[PR #235] [MERGED] adding more test coverage #238

New issue

Closed

opened 2026-03-03 15:30:51 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 15:30:51 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/luthermonson/go-proxmox/pull/235
Author: @luthermonson
Created: 1/21/2026
Status: ✅ Merged
Merged: 1/21/2026
Merged by: @luthermonson

Base: main ← Head: more-coverage

📝 Commits (4)

495c577 adding more test coverage
01eb5ac more vm test coverage
1ae153a adding more node/vm coverage
f982ef3 remove nil check

📊 Changes

20 files changed (+3180 additions, -1 deletions)

View changed files

📝 nodes.go (+1 -1)
📝 nodes_test.go (+402 -0)
➕ storage_test.go (+205 -0)
📝 tasks_test.go (+107 -0)
📝 tests/mocks/pve7x/nodes.go (+307 -0)
📝 tests/mocks/pve7x/proxmox.go (+2 -0)
➕ tests/mocks/pve7x/storage.go (+147 -0)
➕ tests/mocks/pve7x/tasks.go (+117 -0)
📝 tests/mocks/pve8x/nodes.go (+307 -0)
📝 tests/mocks/pve8x/proxmox.go (+2 -0)
➕ tests/mocks/pve8x/storage.go (+147 -0)
➕ tests/mocks/pve8x/tasks.go (+117 -0)
📝 tests/mocks/pve8x/virtual_machines.go (+147 -0)
📝 tests/mocks/pve9x/nodes.go (+307 -0)
📝 tests/mocks/pve9x/proxmox.go (+2 -0)
➕ tests/mocks/pve9x/storage.go (+145 -0)
➕ tests/mocks/pve9x/tasks.go (+117 -0)
📝 tests/mocks/pve9x/virtual_machines.go (+147 -0)
➕ virtual_machine_config_test.go (+222 -0)
📝 virtual_machine_test.go (+232 -0)

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/luthermonson/go-proxmox/pull/235 **Author:** [@luthermonson](https://github.com/luthermonson) **Created:** 1/21/2026 **Status:** ✅ Merged **Merged:** 1/21/2026 **Merged by:** [@luthermonson](https://github.com/luthermonson) **Base:** `main` ← **Head:** `more-coverage` --- ### 📝 Commits (4) - [`495c577`](https://github.com/luthermonson/go-proxmox/commit/495c577996db20339533caa72dbd0822a0247211) adding more test coverage - [`01eb5ac`](https://github.com/luthermonson/go-proxmox/commit/01eb5ac8cffa72435ef72235753100c5d6ba609a) more vm test coverage - [`1ae153a`](https://github.com/luthermonson/go-proxmox/commit/1ae153aaa1bd43cb71cf37a56a1e503ccf7501ae) adding more node/vm coverage - [`f982ef3`](https://github.com/luthermonson/go-proxmox/commit/f982ef3711fa72e16420d2a5eee072789cdd3082) remove nil check ### 📊 Changes **20 files changed** (+3180 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `nodes.go` (+1 -1) 📝 `nodes_test.go` (+402 -0) ➕ `storage_test.go` (+205 -0) 📝 `tasks_test.go` (+107 -0) 📝 `tests/mocks/pve7x/nodes.go` (+307 -0) 📝 `tests/mocks/pve7x/proxmox.go` (+2 -0) ➕ `tests/mocks/pve7x/storage.go` (+147 -0) ➕ `tests/mocks/pve7x/tasks.go` (+117 -0) 📝 `tests/mocks/pve8x/nodes.go` (+307 -0) 📝 `tests/mocks/pve8x/proxmox.go` (+2 -0) ➕ `tests/mocks/pve8x/storage.go` (+147 -0) ➕ `tests/mocks/pve8x/tasks.go` (+117 -0) 📝 `tests/mocks/pve8x/virtual_machines.go` (+147 -0) 📝 `tests/mocks/pve9x/nodes.go` (+307 -0) 📝 `tests/mocks/pve9x/proxmox.go` (+2 -0) ➕ `tests/mocks/pve9x/storage.go` (+145 -0) ➕ `tests/mocks/pve9x/tasks.go` (+117 -0) 📝 `tests/mocks/pve9x/virtual_machines.go` (+147 -0) ➕ `virtual_machine_config_test.go` (+222 -0) 📝 `virtual_machine_test.go` (+232 -0) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>