[PR #230] [MERGED] fix: simplify network interface retrieval in AgentGetNetworkIFaces #232

Closed
opened 2026-03-03 15:30:49 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/luthermonson/go-proxmox/pull/230
Author: @alperencelik
Created: 1/4/2026
Status: Merged
Merged: 1/5/2026
Merged by: @luthermonson

Base: mainHead: main


📝 Commits (1)

  • 6d7433d fix: simplify network interface retrieval in AgentGetNetworkIFaces

📊 Changes

1 file changed (+1 additions, -6 deletions)

View changed files

📝 virtual_machine.go (+1 -6)

📄 Description

I don't see any reason to call node() for that method so I tried to remove that unnecessary call.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/luthermonson/go-proxmox/pull/230 **Author:** [@alperencelik](https://github.com/alperencelik) **Created:** 1/4/2026 **Status:** ✅ Merged **Merged:** 1/5/2026 **Merged by:** [@luthermonson](https://github.com/luthermonson) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (1) - [`6d7433d`](https://github.com/luthermonson/go-proxmox/commit/6d7433dcaabc6a092951b383fa25f35b4abeb76c) fix: simplify network interface retrieval in AgentGetNetworkIFaces ### 📊 Changes **1 file changed** (+1 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `virtual_machine.go` (+1 -6) </details> ### 📄 Description I don't see any reason to call node() for that method so I tried to remove that unnecessary call. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 15:30:49 +03:00
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/go-proxmox#232
No description provided.