[PR #225] [MERGED] fix: node permission #228

Closed
opened 2026-03-03 15:30:47 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/luthermonson/go-proxmox/pull/225
Author: @sergelogvinov
Created: 12/19/2025
Status: Merged
Merged: 12/31/2025
Merged by: @luthermonson

Base: mainHead: node-perms


📝 Commits (1)

📊 Changes

2 files changed (+14 additions, -7 deletions)

View changed files

📝 nodes.go (+14 -6)
📝 nodes_test.go (+0 -1)

📄 Description

Getting the node status requires the Sys.Audit permission, which is quite extensive.
Most calls only need the node name, so they should not fail if this permission is missing (same behavior as in Cluster()).

github.com/luthermonson/go-proxmox@cd684d6404/cluster.go (L10-L20)

Thanks.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/luthermonson/go-proxmox/pull/225 **Author:** [@sergelogvinov](https://github.com/sergelogvinov) **Created:** 12/19/2025 **Status:** ✅ Merged **Merged:** 12/31/2025 **Merged by:** [@luthermonson](https://github.com/luthermonson) **Base:** `main` ← **Head:** `node-perms` --- ### 📝 Commits (1) - [`bc40da2`](https://github.com/luthermonson/go-proxmox/commit/bc40da2344da72f3ed1a153cb9024b5ea0b0e11b) fix: node permission ### 📊 Changes **2 files changed** (+14 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `nodes.go` (+14 -6) 📝 `nodes_test.go` (+0 -1) </details> ### 📄 Description Getting the node status requires the `Sys.Audit` permission, which is quite extensive. Most calls only need the node name, so they should not fail if this permission is missing (same behavior as in Cluster()). https://github.com/luthermonson/go-proxmox/blob/cd684d6404fcf4a83b68d04f2e465135d8faaf97/cluster.go#L10-L20 Thanks. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 15:30:47 +03:00
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/go-proxmox#228
No description provided.