[PR #217] [CLOSED] fix: complete parsing for VirtualMachineConfig and ContainerConfig #223

New issue

Closed

opened 2026-03-03 15:30:46 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 15:30:46 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/luthermonson/go-proxmox/pull/217
Author: @samuelemusiani
Created: 9/21/2025
Status: ❌ Closed

Base: main ← Head: main

📝 Commits (7)

bca41e4 fix: complete parsing for VirtualMachineConfig and ContainerConfig
0ecd842 fix: nil maps
f9c558f removed numas
135501f add: change protection on backups
1ac63bd fix: protected backups
3d3cde5 fix: type on protected backups
5bc8373 add: regenerate cloudinit image

📊 Changes

5 files changed (+191 additions, -429 deletions)

View changed files

➖ container_config.go (+0 -66)
📝 storage.go (+19 -0)
📝 types.go (+168 -226)
📝 virtual_machine.go (+4 -0)
➖ virtual_machine_config.go (+0 -137)

📄 Description

This PR simplify the code a little bit and is related to #211.

In this way a virtual machine (or container) is not more limited on the number of devices and the parsing is more consistent.

THIS PR BREAKS OLD CODE

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/luthermonson/go-proxmox/pull/217 **Author:** [@samuelemusiani](https://github.com/samuelemusiani) **Created:** 9/21/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (7) - [`bca41e4`](https://github.com/luthermonson/go-proxmox/commit/bca41e482e8e38d00f2888ef649bc0a8e826ce60) fix: complete parsing for VirtualMachineConfig and ContainerConfig - [`0ecd842`](https://github.com/luthermonson/go-proxmox/commit/0ecd842564116fc18bdc8efaadbf41b917111dfa) fix: nil maps - [`f9c558f`](https://github.com/luthermonson/go-proxmox/commit/f9c558f64fba370f3eb22cd4d07898fc43a88b74) removed numas - [`135501f`](https://github.com/luthermonson/go-proxmox/commit/135501f5edc69ecb9cc64ad48c330eda61e8956c) add: change protection on backups - [`1ac63bd`](https://github.com/luthermonson/go-proxmox/commit/1ac63bd664640eef4578504100bd7b7a92e8a016) fix: protected backups - [`3d3cde5`](https://github.com/luthermonson/go-proxmox/commit/3d3cde5b27e8c63f2821abcf9e3918c187b4c06e) fix: type on protected backups - [`5bc8373`](https://github.com/luthermonson/go-proxmox/commit/5bc837340bc73d1b3b98e2418c23f07316c2a94d) add: regenerate cloudinit image ### 📊 Changes **5 files changed** (+191 additions, -429 deletions) <details> <summary>View changed files</summary> ➖ `container_config.go` (+0 -66) 📝 `storage.go` (+19 -0) 📝 `types.go` (+168 -226) 📝 `virtual_machine.go` (+4 -0) ➖ `virtual_machine_config.go` (+0 -137) </details> ### 📄 Description This PR simplify the code a little bit and is related to #211. In this way a virtual machine (or container) is not more limited on the number of devices and the parsing is more consistent. ***THIS PR BREAKS OLD CODE*** --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>