[PR #216] [MERGED] fix(access): 🐛 add useroptions type and fix user update function #220

Closed
opened 2026-03-03 15:30:45 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/luthermonson/go-proxmox/pull/216
Author: @kernel-sanders
Created: 9/11/2025
Status: Merged
Merged: 9/23/2025
Merged by: @luthermonson

Base: mainHead: user-update-fix


📝 Commits (1)

  • ee6eebc fix(access): 🐛 fix user update function

📊 Changes

2 files changed (+14 additions, -2 deletions)

View changed files

📝 access.go (+2 -2)
📝 types.go (+12 -0)

📄 Description

The user update function PUTs data that is different from the user object returned from the GET to /access/users/{userid}. Thus a UserOptions struct was created and used in the user Update function. You only need to send the fields you wish to be updated. See https://pve.proxmox.com/pve-docs/api-viewer/#/access/users/{userid} for the API documentation.

Fixes #215


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/luthermonson/go-proxmox/pull/216 **Author:** [@kernel-sanders](https://github.com/kernel-sanders) **Created:** 9/11/2025 **Status:** ✅ Merged **Merged:** 9/23/2025 **Merged by:** [@luthermonson](https://github.com/luthermonson) **Base:** `main` ← **Head:** `user-update-fix` --- ### 📝 Commits (1) - [`ee6eebc`](https://github.com/luthermonson/go-proxmox/commit/ee6eebc71675e37acd26187c31e72687d62cda43) fix(access): 🐛 fix user update function ### 📊 Changes **2 files changed** (+14 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `access.go` (+2 -2) 📝 `types.go` (+12 -0) </details> ### 📄 Description The user update function PUTs data that is different from the user object returned from the GET to /access/users/{userid}. Thus a UserOptions struct was created and used in the user Update function. You only need to send the fields you wish to be updated. See https://pve.proxmox.com/pve-docs/api-viewer/#/access/users/{userid} for the API documentation. Fixes #215 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 15:30:45 +03:00
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/go-proxmox#220
No description provided.