mirror of
https://github.com/luthermonson/go-proxmox.git
synced 2026-04-26 17:35:48 +03:00
[GH-ISSUE #118] complete container support #22
Labels
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/go-proxmox#22
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @xortim on GitHub (Feb 24, 2024).
Original GitHub issue: https://github.com/luthermonson/go-proxmox/issues/118
This looks like a really promising library, thank you for sharing it.
Looking over the PVE API and the functionality implemented in the library. I was thinking the following enhancements would be helpful:
node.NewContainer()POSTto/nodes/{node}/lxcnode.Container()to includecontainer.ConfigThis shouldn't break the existing API and bring it in line with existing VirtualMachine behavior. It would also complete CRUD functionality for PVE containers.
@luthermonson commented on GitHub (Feb 24, 2024):
I spent most of my time in the qemu endpoints that I barely touched the lxc stuff, I did abstract "qemu" to "VirtualMachine" and i dont see why "lxc" shouldn't be "Container" so let's go for it!
@xortim commented on GitHub (Feb 25, 2024):
I'm (slowly) working on a PR for this. It might take a while as I'm a bit rusty with Go.
@luthermonson commented on GitHub (Feb 25, 2024):
i tried to abstract the complexities so most get/put/post/delete aren't much more than a couple lines. you'll do fine and we can fix anything after you put up a PR
@luthermonson commented on GitHub (Mar 7, 2024):
@xortim i think someone beat you to it #126, closing this for now but feel free to open new ones if anything was missed