starred/go-proxmox
1
0
Fork 0
mirror of https://github.com/luthermonson/go-proxmox.git synced 2026-04-26 09:25:53 +03:00
Code Issues 25 Projects Releases 5 Packages Wiki Activity

[PR #210] [MERGED] Fix issue with omitempty and bool values conflicting with Proxmox API defaults #218

New issue
Closed
opened 2026-03-03 15:30:45 +03:00 by kerem · 0 comments
kerem commented 2026-03-03 15:30:45 +03:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/luthermonson/go-proxmox/pull/210
Author: @kernel-sanders
Created: 8/15/2025
Status: ✅ Merged
Merged: 8/18/2025
Merged by: @luthermonson

Base: main ← Head: main

📝 Commits (2)

  • ab221f3 fix: 🐛 fix bug where passing false to Privsep for token creation would omit the value (bool's zero value is false) and thus Proxmox would use it's default (true)
  • afc40b1 fix: 🐛 fix issue where omitempty prevents a setting due to the default being true

📊 Changes

1 file changed (+8 additions, -8 deletions)

View changed files

📝 types.go (+8 -8)

📄 Description

Fixes #209

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/luthermonson/go-proxmox/pull/210 **Author:** [@kernel-sanders](https://github.com/kernel-sanders) **Created:** 8/15/2025 **Status:** ✅ Merged **Merged:** 8/18/2025 **Merged by:** [@luthermonson](https://github.com/luthermonson) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (2) - [`ab221f3`](https://github.com/luthermonson/go-proxmox/commit/ab221f332d5de5777d41ed4370de02c944fbdfd8) fix: 🐛 fix bug where passing false to Privsep for token creation would omit the value (bool's zero value is false) and thus Proxmox would use it's default (true) - [`afc40b1`](https://github.com/luthermonson/go-proxmox/commit/afc40b104cc449c6799a96f11732e542f8933ac1) fix: 🐛 fix issue where omitempty prevents a setting due to the default being true ### 📊 Changes **1 file changed** (+8 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `types.go` (+8 -8) </details> ### 📄 Description Fixes #209 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 15:30:45 +03:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
fix-storage
more-coverage
group-tests
codecov
v0.4.1
v0.4.0
v0.3.2
v0.3.1
v0.3.0
v0.2.4
v0.2.3
v0.2.2
v0.2.1
v0.2.0
v0.1.1
v0.1.0
v0.0.0-beta6
v0.0.0-beta5
v0.0.0-beta4
v0.0.0-beta3
v0.0.0-beta2
v0.0.0-beta1
v0.0.0-alpha10
v0.0.0-alpha9
v0.0.0-alpha8
v0.0.0-alpha7
v0.0.0-alpha6
v0.0.0-alpha5
v0.0.0-alpha4
v0.0.0-alpha3
v0.0.0-alpha2
v0.0.0-alpha1
tests
Labels
Clear labels   
pull-request

Mirrored from GitHub Pull Request

No labels
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/go-proxmox#218
No description provided.