[PR #205] [MERGED] Skip disabled storage in Node.findStorageByContent #214

New issue

Closed

opened 2026-03-03 15:30:44 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 15:30:44 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/luthermonson/go-proxmox/pull/205
Author: @LukasK32
Created: 7/4/2025
Status: ✅ Merged
Merged: 7/4/2025
Merged by: @luthermonson

Base: main ← Head: skip-disabled-storage

📝 Commits (1)

18db7ae Skip disabled storages in Node.findStorageByContent

📊 Changes

1 file changed (+4 additions, -0 deletions)

View changed files

📝 nodes.go (+4 -0)

📄 Description

Node.findStorageByContent can return a disabled storage. This breaks ISO injection in cases where there are multiple ISO storages on the node, but some of them are disabled, with error 500 storage 'local' is disabled.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/luthermonson/go-proxmox/pull/205 **Author:** [@LukasK32](https://github.com/LukasK32) **Created:** 7/4/2025 **Status:** ✅ Merged **Merged:** 7/4/2025 **Merged by:** [@luthermonson](https://github.com/luthermonson) **Base:** `main` ← **Head:** `skip-disabled-storage` --- ### 📝 Commits (1) - [`18db7ae`](https://github.com/luthermonson/go-proxmox/commit/18db7ae61de52ab5bfd9430f1c9ca1699c0d91d6) Skip disabled storages in Node.findStorageByContent ### 📊 Changes **1 file changed** (+4 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `nodes.go` (+4 -0) </details> ### 📄 Description `Node.findStorageByContent` can return a disabled storage. This breaks ISO injection in cases where there are multiple ISO storages on the node, but some of them are disabled, with error `500 storage 'local' is disabled`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>