[PR #192] [MERGED] Adding firewall IPSet functionality #206

New issue

Closed

opened 2026-03-03 15:30:42 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 15:30:42 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/luthermonson/go-proxmox/pull/192
Author: @javaexceptionde
Created: 5/6/2025
Status: ✅ Merged
Merged: 5/17/2025
Merged by: @luthermonson

Base: main ← Head: main

📝 Commits (5)

d2d4ccc feat: firewall: Add IPSet and IPSetEntry management functions
ffa5b35 fix: validate inputs for firewall IPSet creation
7e01f4a refactor: firewall: Simplify input validation for IP set functions
0763152 refactor(virtual_machine): Simplify parameter types in methods
1808b43 refactor(virtual_machine): Rename receiver from 'c' to 'v'

📊 Changes

3 files changed (+85 additions, -1 deletions)

View changed files

📝 containers.go (+24 -1)
📝 types.go (+26 -0)
📝 virtual_machine.go (+35 -0)

📄 Description

Introduce new methods to manage Firewall IPSet and IPSetEntries for both VirtualMachine and Container. Functions include creation, retrieval, updating, and deletion of IPSets and their entries. Added corresponding struct types for IPSet and IPSetEntry handling options.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/luthermonson/go-proxmox/pull/192 **Author:** [@javaexceptionde](https://github.com/javaexceptionde) **Created:** 5/6/2025 **Status:** ✅ Merged **Merged:** 5/17/2025 **Merged by:** [@luthermonson](https://github.com/luthermonson) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (5) - [`d2d4ccc`](https://github.com/luthermonson/go-proxmox/commit/d2d4ccc1392165445fe7113514172a9e32b6351a) feat: firewall: Add IPSet and IPSetEntry management functions - [`ffa5b35`](https://github.com/luthermonson/go-proxmox/commit/ffa5b353cd0b34b2593046b7f650edec82ef5198) fix: validate inputs for firewall IPSet creation - [`7e01f4a`](https://github.com/luthermonson/go-proxmox/commit/7e01f4a60d3cf42f2624a89939a1a34110a8aae9) refactor: firewall: Simplify input validation for IP set functions - [`0763152`](https://github.com/luthermonson/go-proxmox/commit/0763152af350e1d7c6b5441a451274630de616e9) refactor(virtual_machine): Simplify parameter types in methods - [`1808b43`](https://github.com/luthermonson/go-proxmox/commit/1808b432a7dbcdacff804bfb3a83a8779e739b42) refactor(virtual_machine): Rename receiver from 'c' to 'v' ### 📊 Changes **3 files changed** (+85 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `containers.go` (+24 -1) 📝 `types.go` (+26 -0) 📝 `virtual_machine.go` (+35 -0) </details> ### 📄 Description Introduce new methods to manage Firewall IPSet and IPSetEntries for both VirtualMachine and Container. Functions include creation, retrieval, updating, and deletion of IPSets and their entries. Added corresponding struct types for IPSet and IPSetEntry handling options. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-03 15:30:42 +03:00

closed this issue
added the
pull-request
label

No labels

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/go-proxmox#206

No description provided.

Rows
Columns