[PR #179] [MERGED] fix: add correct RRD Data format and fix the variadic function #200

Closed
opened 2026-03-03 15:30:40 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/luthermonson/go-proxmox/pull/179
Author: @dragonis41
Created: 11/21/2024
Status: Merged
Merged: 3/25/2025
Merged by: @luthermonson

Base: mainHead: fix/rrddata


📝 Commits (5)

  • 41312cb fix: add correct RRD Data format and fix the variatic function
  • e6d504f fix: also fix variatic function on containers
  • fd3fbd1 fix: fix Container.RRDData() function definition
  • 1d84b8d Merge branch 'luthermonson:main' into fix/rrddata
  • e8c2797 ci: rename variables to match naming specifications

📊 Changes

3 files changed (+23 additions, -19 deletions)

View changed files

📝 containers.go (+6 -7)
📝 types.go (+12 -6)
📝 virtual_machine.go (+5 -6)

📄 Description

Related to the issue #112.

I have added correct structure to receive the rrd datas and added a check in the variatic function because Proxmox does not allow to receive an array as a consolidation function.

Have a good day 🚀


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/luthermonson/go-proxmox/pull/179 **Author:** [@dragonis41](https://github.com/dragonis41) **Created:** 11/21/2024 **Status:** ✅ Merged **Merged:** 3/25/2025 **Merged by:** [@luthermonson](https://github.com/luthermonson) **Base:** `main` ← **Head:** `fix/rrddata` --- ### 📝 Commits (5) - [`41312cb`](https://github.com/luthermonson/go-proxmox/commit/41312cb894e7b2f2749e67a3fac45b2abadfbde3) fix: add correct RRD Data format and fix the variatic function - [`e6d504f`](https://github.com/luthermonson/go-proxmox/commit/e6d504f3747296595fec940af8c283ce91672338) fix: also fix variatic function on containers - [`fd3fbd1`](https://github.com/luthermonson/go-proxmox/commit/fd3fbd10d90d0b80194f90851b3ae4aa768f0436) fix: fix Container.RRDData() function definition - [`1d84b8d`](https://github.com/luthermonson/go-proxmox/commit/1d84b8deb0287eb73c6801b225023cff1110e674) Merge branch 'luthermonson:main' into fix/rrddata - [`e8c2797`](https://github.com/luthermonson/go-proxmox/commit/e8c279709a7236c11950b252dd0a2c2428fc0ae1) ci: rename variables to match naming specifications ### 📊 Changes **3 files changed** (+23 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `containers.go` (+6 -7) 📝 `types.go` (+12 -6) 📝 `virtual_machine.go` (+5 -6) </details> ### 📄 Description Related to the issue #112. I have added correct structure to receive the rrd datas and added a check in the variatic function because Proxmox does not allow to receive an array as a consolidation function. Have a good day :rocket: --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 15:30:40 +03:00
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/go-proxmox#200
No description provided.