[PR #170] [MERGED] Fix VM state functions #194

New issue

Closed

opened 2026-03-03 15:30:38 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 15:30:38 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/luthermonson/go-proxmox/pull/170
Author: @rybnico
Created: 10/8/2024
Status: ✅ Merged
Merged: 10/8/2024
Merged by: @luthermonson

Base: main ← Head: fix-vm-is-paused

📝 Commits (3)

873dfcf Fix VirtualMachine.IsPaused
21d1eed Fix VirtualMachine state functions
020b543 Merge remote-tracking branch 'origin/main' into fix-vm-is-paused

📊 Changes

2 files changed (+38 additions, -7 deletions)

View changed files

📝 virtual_machine.go (+3 -3)
📝 virtual_machine_test.go (+35 -4)

📄 Description

The fix for #139 (#166) breaks some VirtualMachine state functions.

I have tried to implement the functions in a way that works with and without a VirtualMachine.QMPStatus. Without a QMPStatus, we can't be sure of the paused state (because the Status of a paused VM is still Running).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/luthermonson/go-proxmox/pull/170 **Author:** [@rybnico](https://github.com/rybnico) **Created:** 10/8/2024 **Status:** ✅ Merged **Merged:** 10/8/2024 **Merged by:** [@luthermonson](https://github.com/luthermonson) **Base:** `main` ← **Head:** `fix-vm-is-paused` --- ### 📝 Commits (3) - [`873dfcf`](https://github.com/luthermonson/go-proxmox/commit/873dfcf9e0cd9a6dd8f092228eadffdfe574e3a8) Fix VirtualMachine.IsPaused - [`21d1eed`](https://github.com/luthermonson/go-proxmox/commit/21d1eed025a12a2d208fca01ee5389b76f0283af) Fix VirtualMachine state functions - [`020b543`](https://github.com/luthermonson/go-proxmox/commit/020b543ac0e8de7179c964e4214302d00112ee74) Merge remote-tracking branch 'origin/main' into fix-vm-is-paused ### 📊 Changes **2 files changed** (+38 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `virtual_machine.go` (+3 -3) 📝 `virtual_machine_test.go` (+35 -4) </details> ### 📄 Description The fix for #139 (#166) breaks some VirtualMachine state functions. I have tried to implement the functions in a way that works with and without a `VirtualMachine.QMPStatus`. Without a `QMPStatus`, we can't be sure of the paused state (because the `Status` of a paused VM is still `Running`). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>