[PR #161] [MERGED] Re-Implementation of Term and VNC Features. #188

New issue

Closed

opened 2026-03-03 15:30:36 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 15:30:36 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/luthermonson/go-proxmox/pull/161
Author: @ricardoalcantara
Created: 9/13/2024
Status: ✅ Merged
Merged: 9/18/2024
Merged by: @luthermonson

Base: main ← Head: main

📝 Commits (4)

07d287a Removing unnecessary break line
45d52a3 New Term and VNC Impl v1
8737301 Fix: TestNode_TermProxy
f714768 Add: TestNode_VncProxy

📊 Changes

10 files changed (+274 additions, -114 deletions)

View changed files

📝 containers.go (+10 -3)
📝 nodes.go (+10 -3)
📝 proxmox.go (+86 -8)
📝 tests/integration/nodes_test.go (+63 -25)
📝 tests/integration/proxmox_test.go (+8 -1)
📝 tests/integration/storage_test.go (+17 -16)
📝 tests/integration/tasks_test.go (+6 -5)
📝 tests/integration/virtual_machines_test.go (+47 -46)
📝 types.go (+15 -2)
📝 virtual_machine.go (+12 -5)

📄 Description

Hi, recently I opened two issues:

#147: This issue was caused by a breakline that prevented me from using xtermjs.org. After removing the breakline, it worked fine.
#148: I was unable to use VNC at all.
After some research, I decided to re-implement the solution since I use this library frequently, and these features are important to me.

Additionally, I created a proof of concept (POC), hosted in this repository: https://github.com/ricardoalcantara/go-proxmox-term-and-vnc, which I will soon incorporate into my own project.

I would like to contribute my work and I'm open to further discussion.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/luthermonson/go-proxmox/pull/161 **Author:** [@ricardoalcantara](https://github.com/ricardoalcantara) **Created:** 9/13/2024 **Status:** ✅ Merged **Merged:** 9/18/2024 **Merged by:** [@luthermonson](https://github.com/luthermonson) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (4) - [`07d287a`](https://github.com/luthermonson/go-proxmox/commit/07d287ab4791ed420435f8e848c7ee0dba08c880) Removing unnecessary break line - [`45d52a3`](https://github.com/luthermonson/go-proxmox/commit/45d52a36d099db8874a1ad077f778c668eb03371) New Term and VNC Impl v1 - [`8737301`](https://github.com/luthermonson/go-proxmox/commit/8737301a9d0bbe562634ebffbb782fc412aff7d4) Fix: TestNode_TermProxy - [`f714768`](https://github.com/luthermonson/go-proxmox/commit/f714768837e053270ed9f352cdf5bc6cac7c0859) Add: TestNode_VncProxy ### 📊 Changes **10 files changed** (+274 additions, -114 deletions) <details> <summary>View changed files</summary> 📝 `containers.go` (+10 -3) 📝 `nodes.go` (+10 -3) 📝 `proxmox.go` (+86 -8) 📝 `tests/integration/nodes_test.go` (+63 -25) 📝 `tests/integration/proxmox_test.go` (+8 -1) 📝 `tests/integration/storage_test.go` (+17 -16) 📝 `tests/integration/tasks_test.go` (+6 -5) 📝 `tests/integration/virtual_machines_test.go` (+47 -46) 📝 `types.go` (+15 -2) 📝 `virtual_machine.go` (+12 -5) </details> ### 📄 Description Hi, recently I opened two issues: #147: This issue was caused by a breakline that prevented me from using xtermjs.org. After removing the breakline, it worked fine. #148: I was unable to use VNC at all. After some research, I decided to re-implement the solution since I use this library frequently, and these features are important to me. Additionally, I created a proof of concept (POC), hosted in this repository: https://github.com/ricardoalcantara/go-proxmox-term-and-vnc, which I will soon incorporate into my own project. I would like to contribute my work and I'm open to further discussion. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>