[PR #159] [MERGED] Feature: add ContainerConfig to Container #185

Closed
opened 2026-03-03 15:30:35 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/luthermonson/go-proxmox/pull/159
Author: @xortim
Created: 9/5/2024
Status: Merged
Merged: 9/18/2024
Merged by: @luthermonson

Base: mainHead: feature/container-config


📝 Commits (3)

  • a0f585d Adds ContainerConfig to Container
  • f07887d fix casing as suggested
  • 567b234 add fixtures and rudimentary test for Container

📊 Changes

6 files changed (+151 additions, -14 deletions)

View changed files

📝 containers.go (+2 -0)
📝 containers_test.go (+16 -1)
📝 nodes.go (+10 -4)
📝 tests/mocks/pve7x/nodes.go (+43 -1)
📝 tests/mocks/pve8x/nodes.go (+0 -1)
📝 types.go (+80 -7)

📄 Description

Add ContainerConfig to Container similar to VIrtualMachineConfig


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/luthermonson/go-proxmox/pull/159 **Author:** [@xortim](https://github.com/xortim) **Created:** 9/5/2024 **Status:** ✅ Merged **Merged:** 9/18/2024 **Merged by:** [@luthermonson](https://github.com/luthermonson) **Base:** `main` ← **Head:** `feature/container-config` --- ### 📝 Commits (3) - [`a0f585d`](https://github.com/luthermonson/go-proxmox/commit/a0f585d4de3f37b1457a1fed0e5a9ff88d052b38) Adds ContainerConfig to Container - [`f07887d`](https://github.com/luthermonson/go-proxmox/commit/f07887de7b98ff1abd54aa9dcf6fc33e01afb831) fix casing as suggested - [`567b234`](https://github.com/luthermonson/go-proxmox/commit/567b234471cebc277abf2406e8ef425f5fbc2c2c) add fixtures and rudimentary test for Container ### 📊 Changes **6 files changed** (+151 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `containers.go` (+2 -0) 📝 `containers_test.go` (+16 -1) 📝 `nodes.go` (+10 -4) 📝 `tests/mocks/pve7x/nodes.go` (+43 -1) 📝 `tests/mocks/pve8x/nodes.go` (+0 -1) 📝 `types.go` (+80 -7) </details> ### 📄 Description Add ContainerConfig to Container similar to VIrtualMachineConfig --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 15:30:35 +03:00
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/go-proxmox#185
No description provided.