[PR #141] [MERGED] Fix AgentExec when no pid returned #175

New issue

Closed

opened 2026-03-03 15:30:32 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 15:30:32 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/luthermonson/go-proxmox/pull/141
Author: @mcbenjemaa
Created: 4/2/2024
Status: ✅ Merged
Merged: 4/2/2024
Merged by: @luthermonson

Base: main ← Head: fix-pid

📝 Commits (1)

d53019e Fix AgentExec when no pid returned

📊 Changes

1 file changed (+6 additions, -1 deletions)

View changed files

📝 virtual_machine.go (+6 -1)

📄 Description

That caused a panic:

Fix the AgentExec func to return error if no pid, has returned.

oup="infrastructure.cluster.x-k8s.io" controllerKind="ProxmoxMachine" ProxmoxMachine="default/test-dev-control-plane-ptkhg" namespace="default" name="test-dev-control-plane-ptkhg" reconcileID="8013f2cd-4d25-4072-9c80-7d79af7191a4" panic: interface conversion: interface {} is nil, not float64 [recovered] panic: interface conversion: interface {} is nil, not float64

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/luthermonson/go-proxmox/pull/141 **Author:** [@mcbenjemaa](https://github.com/mcbenjemaa) **Created:** 4/2/2024 **Status:** ✅ Merged **Merged:** 4/2/2024 **Merged by:** [@luthermonson](https://github.com/luthermonson) **Base:** `main` ← **Head:** `fix-pid` --- ### 📝 Commits (1) - [`d53019e`](https://github.com/luthermonson/go-proxmox/commit/d53019e152373abaf16e935507a1e3a8492ba5b4) Fix AgentExec when no pid returned ### 📊 Changes **1 file changed** (+6 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `virtual_machine.go` (+6 -1) </details> ### 📄 Description That caused a panic: Fix the AgentExec func to return error if no pid, has returned. `oup="infrastructure.cluster.x-k8s.io" controllerKind="ProxmoxMachine" ProxmoxMachine="default/test-dev-control-plane-ptkhg" namespace="default" name="test-dev-control-plane-ptkhg" reconcileID="8013f2cd-4d25-4072-9c80-7d79af7191a4" panic: interface conversion: interface {} is nil, not float64 [recovered] panic: interface conversion: interface {} is nil, not float64 ` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>