[PR #106] [MERGED] Fix live migrations #154

Closed
opened 2026-03-03 15:30:27 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/luthermonson/go-proxmox/pull/106
Author: @jqueuniet
Created: 11/20/2023
Status: Merged
Merged: 11/26/2023
Merged by: @luthermonson

Base: mainHead: fix_live_migration


📝 Commits (2)

  • 42ff65d Fix live migrations
  • 45993ac Rework qemu migration to follow the Clone model

📊 Changes

2 files changed (+20 additions, -7 deletions)

View changed files

📝 types.go (+11 -0)
📝 virtual_machine.go (+9 -7)

📄 Description

Add missing flags to allow live migration, with local disks.

Those flags are not supposed to do anything with offline VM and shouldn't change the current behavior too much, except if someone relied on migration failing.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/luthermonson/go-proxmox/pull/106 **Author:** [@jqueuniet](https://github.com/jqueuniet) **Created:** 11/20/2023 **Status:** ✅ Merged **Merged:** 11/26/2023 **Merged by:** [@luthermonson](https://github.com/luthermonson) **Base:** `main` ← **Head:** `fix_live_migration` --- ### 📝 Commits (2) - [`42ff65d`](https://github.com/luthermonson/go-proxmox/commit/42ff65db45c9243e4140174c46270da7f6afff68) Fix live migrations - [`45993ac`](https://github.com/luthermonson/go-proxmox/commit/45993ac829f61c4e3fa7d0169a6601cb9b9150f9) Rework qemu migration to follow the Clone model ### 📊 Changes **2 files changed** (+20 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `types.go` (+11 -0) 📝 `virtual_machine.go` (+9 -7) </details> ### 📄 Description Add missing flags to allow live migration, with local disks. Those flags are not supposed to do anything with offline VM and shouldn't change the current behavior too much, except if someone relied on migration failing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 15:30:27 +03:00
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/go-proxmox#154
No description provided.