[PR #88] [MERGED] adding missing networks fields, moving networks to own file, added network(s) tests #138

New issue

Closed

opened 2026-03-03 15:30:22 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 15:30:22 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/luthermonson/go-proxmox/pull/88
Author: @luthermonson
Created: 8/27/2023
Status: ✅ Merged
Merged: 8/28/2023
Merged by: @luthermonson

Base: main ← Head: network-updates

📝 Commits (1)

601e29b moving networks to own file, added network(s) tests

📊 Changes

6 files changed (+208 additions, -92 deletions)

View changed files

➖ networks.go (+0 -18)
📝 nodes.go (+0 -53)
➕ nodes_network.go (+76 -0)
➕ nodes_network_test.go (+36 -0)
📝 tests/mocks/pve7x/nodes.go (+66 -2)
📝 types.go (+30 -19)

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/luthermonson/go-proxmox/pull/88 **Author:** [@luthermonson](https://github.com/luthermonson) **Created:** 8/27/2023 **Status:** ✅ Merged **Merged:** 8/28/2023 **Merged by:** [@luthermonson](https://github.com/luthermonson) **Base:** `main` ← **Head:** `network-updates` --- ### 📝 Commits (1) - [`601e29b`](https://github.com/luthermonson/go-proxmox/commit/601e29bcfed050dd0221e130cdddddf36a8a2a3e) moving networks to own file, added network(s) tests ### 📊 Changes **6 files changed** (+208 additions, -92 deletions) <details> <summary>View changed files</summary> ➖ `networks.go` (+0 -18) 📝 `nodes.go` (+0 -53) ➕ `nodes_network.go` (+76 -0) ➕ `nodes_network_test.go` (+36 -0) 📝 `tests/mocks/pve7x/nodes.go` (+66 -2) 📝 `types.go` (+30 -19) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-03 15:30:22 +03:00

closed this issue
added the
pull-request
label

No labels

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/go-proxmox#138

No description provided.

Rows
Columns