[PR #81] [MERGED] refactor pools to drop PoolAPI and add pool resource filters #131

New issue

Closed

opened 2026-03-03 15:30:21 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 15:30:21 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/luthermonson/go-proxmox/pull/81
Author: @luthermonson
Created: 8/26/2023
Status: ✅ Merged
Merged: 8/26/2023
Merged by: @luthermonson

Base: main ← Head: pools-refactor

📝 Commits (1)

973de5c refactor pools to drop PoolAPI and add pool resource filters

📊 Changes

4 files changed (+54 additions, -41 deletions)

View changed files

📝 pools.go (+29 -18)
📝 pools_test.go (+10 -11)
📝 tests/mocks/pve7x/pools.go (+13 -1)
📝 types.go (+2 -11)

📄 Description

removed PoolAPI in favor of top level Pool(s)
added filter for cluster resources to Pool
replaced Create with NewPool

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/luthermonson/go-proxmox/pull/81 **Author:** [@luthermonson](https://github.com/luthermonson) **Created:** 8/26/2023 **Status:** ✅ Merged **Merged:** 8/26/2023 **Merged by:** [@luthermonson](https://github.com/luthermonson) **Base:** `main` ← **Head:** `pools-refactor` --- ### 📝 Commits (1) - [`973de5c`](https://github.com/luthermonson/go-proxmox/commit/973de5c688ce2c8b67680ef9798bfde5b51e1ce7) refactor pools to drop PoolAPI and add pool resource filters ### 📊 Changes **4 files changed** (+54 additions, -41 deletions) <details> <summary>View changed files</summary> 📝 `pools.go` (+29 -18) 📝 `pools_test.go` (+10 -11) 📝 `tests/mocks/pve7x/pools.go` (+13 -1) 📝 `types.go` (+2 -11) </details> ### 📄 Description * removed PoolAPI in favor of top level `Pool(s)` * added filter for cluster resources to Pool * replaced `Create` with `NewPool` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>