[PR #80] [MERGED] Fix warnings raised by Goland #130

Closed
opened 2026-03-03 15:30:20 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/luthermonson/go-proxmox/pull/80
Author: @jqueuniet
Created: 8/24/2023
Status: Merged
Merged: 8/24/2023
Merged by: @luthermonson

Base: mainHead: fix_goland_warnings


📝 Commits (1)

  • 21cd54e Fix a few warnings raised by Goland

📊 Changes

12 files changed (+37 additions, -30 deletions)

View changed files

📝 logger.go (+4 -4)
📝 mage/install/install.go (+2 -2)
📝 mage/test/test.go (+4 -4)
📝 proxmox.go (+7 -7)
📝 storage.go (+4 -1)
📝 tasks.go (+5 -2)
📝 tasks_test.go (+1 -1)
📝 tests/integration/tasks_test.go (+1 -1)
📝 tests/integration/virtual_machines_test.go (+1 -1)
📝 types.go (+5 -4)
📝 virtual_machine.go (+2 -2)
📝 virtual_machine_config.go (+1 -1)

📄 Description

This PR aims to solve part of the warnings raised by the Goland IDE. Leaving aside a few potentially more controversial ones (like unused unexported functions or deferring without handling errors).


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/luthermonson/go-proxmox/pull/80 **Author:** [@jqueuniet](https://github.com/jqueuniet) **Created:** 8/24/2023 **Status:** ✅ Merged **Merged:** 8/24/2023 **Merged by:** [@luthermonson](https://github.com/luthermonson) **Base:** `main` ← **Head:** `fix_goland_warnings` --- ### 📝 Commits (1) - [`21cd54e`](https://github.com/luthermonson/go-proxmox/commit/21cd54e58247473fd6e79e1e7019365626dcf2b1) Fix a few warnings raised by Goland ### 📊 Changes **12 files changed** (+37 additions, -30 deletions) <details> <summary>View changed files</summary> 📝 `logger.go` (+4 -4) 📝 `mage/install/install.go` (+2 -2) 📝 `mage/test/test.go` (+4 -4) 📝 `proxmox.go` (+7 -7) 📝 `storage.go` (+4 -1) 📝 `tasks.go` (+5 -2) 📝 `tasks_test.go` (+1 -1) 📝 `tests/integration/tasks_test.go` (+1 -1) 📝 `tests/integration/virtual_machines_test.go` (+1 -1) 📝 `types.go` (+5 -4) 📝 `virtual_machine.go` (+2 -2) 📝 `virtual_machine_config.go` (+1 -1) </details> ### 📄 Description This PR aims to solve part of the warnings raised by the Goland IDE. Leaving aside a few potentially more controversial ones (like unused unexported functions or deferring without handling errors). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 15:30:20 +03:00
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/go-proxmox#130
No description provided.