[PR #77] [MERGED] Do not fail if cloudinit iso is not found #127

New issue

Closed

opened 2026-03-03 15:30:19 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 15:30:19 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/luthermonson/go-proxmox/pull/77
Author: @mcbenjemaa
Created: 8/22/2023
Status: ✅ Merged
Merged: 8/22/2023
Merged by: @luthermonson

Base: main ← Head: cloud-iso

📝 Commits (1)

24d41f7 Do not fail if cloudinit iso is not found

📊 Changes

1 file changed (+21 additions, -11 deletions)

View changed files

📝 virtual_machine.go (+21 -11)

📄 Description

I have this error in my reconciler,

E0822 14:41:42.914961     116 controller.go:324] "Reconciler error" err="cannot delete vm with id 105: 500 volume_size_info on 'local:iso/user-data-105.iso' failed" controller="proxmoxmachine" controllerGroup="infrastructure.cluster.x-k8s.io" controllerKind="ProxmoxMachine" ProxmoxMachine="default/proxmox-test-control-plane-86mrg" namespace="default" name="proxmox-test-control-plane-86mrg" reconcileID=7ebc73fd-79c5-45ce-9197-eb711535a2b7

which seems that the cloudinit iso was deleted, but the vm.Delete() is failing cause it has the cloudinit tag.

This will make the Delete to not fail, if the iso is not found.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/luthermonson/go-proxmox/pull/77 **Author:** [@mcbenjemaa](https://github.com/mcbenjemaa) **Created:** 8/22/2023 **Status:** ✅ Merged **Merged:** 8/22/2023 **Merged by:** [@luthermonson](https://github.com/luthermonson) **Base:** `main` ← **Head:** `cloud-iso` --- ### 📝 Commits (1) - [`24d41f7`](https://github.com/luthermonson/go-proxmox/commit/24d41f7f2435367bc00a844a8023a31b06ff8ca9) Do not fail if cloudinit iso is not found ### 📊 Changes **1 file changed** (+21 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `virtual_machine.go` (+21 -11) </details> ### 📄 Description I have this error in my reconciler, ``` E0822 14:41:42.914961 116 controller.go:324] "Reconciler error" err="cannot delete vm with id 105: 500 volume_size_info on 'local:iso/user-data-105.iso' failed" controller="proxmoxmachine" controllerGroup="infrastructure.cluster.x-k8s.io" controllerKind="ProxmoxMachine" ProxmoxMachine="default/proxmox-test-control-plane-86mrg" namespace="default" name="proxmox-test-control-plane-86mrg" reconcileID=7ebc73fd-79c5-45ce-9197-eb711535a2b7 ``` which seems that the cloudinit iso was deleted, but the `vm.Delete()` is failing cause it has the cloudinit tag. This will make the Delete to not fail, if the iso is not found. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>