[PR #74] [MERGED] Deprecate Old Access funcs in Favor of Options #124

New issue

Closed

opened 2026-03-03 15:30:18 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 15:30:18 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/luthermonson/go-proxmox/pull/74
Author: @luthermonson
Created: 8/19/2023
Status: ✅ Merged
Merged: 8/20/2023
Merged by: @luthermonson

Base: main ← Head: access-tests

📝 Commits (1)

29c54ea rework access to use options, added permissions

📊 Changes

10 files changed (+579 additions, -51 deletions)

View changed files

📝 README.md (+10 -6)
📝 access.go (+21 -0)
➕ access_test.go (+59 -0)
📝 options.go (+16 -6)
📝 options_test.go (+9 -1)
📝 proxmox.go (+1 -1)
📝 proxmox_test.go (+4 -0)
📝 tests/integration/access_test.go (+0 -31)
📝 tests/mocks/pve7x/access.go (+444 -2)
📝 types.go (+15 -4)

📄 Description

Reworked access to use all the options properly
Deprecated functions in favor of options
Added permissions

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/luthermonson/go-proxmox/pull/74 **Author:** [@luthermonson](https://github.com/luthermonson) **Created:** 8/19/2023 **Status:** ✅ Merged **Merged:** 8/20/2023 **Merged by:** [@luthermonson](https://github.com/luthermonson) **Base:** `main` ← **Head:** `access-tests` --- ### 📝 Commits (1) - [`29c54ea`](https://github.com/luthermonson/go-proxmox/commit/29c54eaa5164f5f56e1224e284554b7da1ea01a0) rework access to use options, added permissions ### 📊 Changes **10 files changed** (+579 additions, -51 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+10 -6) 📝 `access.go` (+21 -0) ➕ `access_test.go` (+59 -0) 📝 `options.go` (+16 -6) 📝 `options_test.go` (+9 -1) 📝 `proxmox.go` (+1 -1) 📝 `proxmox_test.go` (+4 -0) 📝 `tests/integration/access_test.go` (+0 -31) 📝 `tests/mocks/pve7x/access.go` (+444 -2) 📝 `types.go` (+15 -4) </details> ### 📄 Description * Reworked access to use all the options properly * Deprecated functions in favor of options * Added permissions --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>