[PR #71] [MERGED] adding StringOrFloat64 #121

New issue

Closed

opened 2026-03-03 15:30:18 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 15:30:18 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/luthermonson/go-proxmox/pull/71
Author: @luthermonson
Created: 8/9/2023
Status: ✅ Merged
Merged: 8/9/2023
Merged by: @luthermonson

Base: main ← Head: stringorfloat32

📝 Commits (1)

0e07d02 adding StringOrFloat64

📊 Changes

2 files changed (+324 additions, -18 deletions)

View changed files

📝 types.go (+48 -18)
➕ types_test.go (+276 -0)

📄 Description

moving CPULimit to use new StringOrFloat64 type
added tests around all Or types
fixed regex to allow all floats to be used as Or types
fixed error checking throughout Or types to give error responses to parse/validation errors to catch future api issues instead of blindingly returning 0

fixes #69

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/luthermonson/go-proxmox/pull/71 **Author:** [@luthermonson](https://github.com/luthermonson) **Created:** 8/9/2023 **Status:** ✅ Merged **Merged:** 8/9/2023 **Merged by:** [@luthermonson](https://github.com/luthermonson) **Base:** `main` ← **Head:** `stringorfloat32` --- ### 📝 Commits (1) - [`0e07d02`](https://github.com/luthermonson/go-proxmox/commit/0e07d02634798475ed1ee728d0b002c436026135) adding StringOrFloat64 ### 📊 Changes **2 files changed** (+324 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `types.go` (+48 -18) ➕ `types_test.go` (+276 -0) </details> ### 📄 Description * moving CPULimit to use new StringOrFloat64 type * added tests around all `Or` types * fixed regex to allow all floats to be used as Or types * fixed error checking throughout `Or` types to give error responses to parse/validation errors to catch future api issues instead of blindingly returning `0` fixes #69 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>