mirror of
https://github.com/luthermonson/go-proxmox.git
synced 2026-04-26 09:25:53 +03:00
[PR #70] [MERGED] adding noop error and ignoring task from addtag in cloudinit #119
Labels
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/go-proxmox#119
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/luthermonson/go-proxmox/pull/70
Author: @luthermonson
Created: 8/9/2023
Status: ✅ Merged
Merged: 8/9/2023
Merged by: @luthermonson
Base:
main← Head:fix-addtag📝 Commits (1)
39430a8adding noop error and ignoring task from addtag in cloudinit📊 Changes
2 files changed (+14 additions, -11 deletions)
View changed files
📝
proxmox.go(+6 -0)📝
virtual_machine.go(+8 -11)📄 Description
regrets were have returning nil nil, adding a noop error type in case this happens again and decided to ultimately ignore the returned task in cloud init func since there wasn't much benefit to waiting for it to get done if we do actually call it
fixes #68
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.