[PR #56] [CLOSED] fix character in paths and tests #110

New issue

Closed

opened 2026-03-03 15:30:14 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 15:30:14 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/luthermonson/go-proxmox/pull/56
Author: @jonasferoz
Created: 3/25/2023
Status: ❌ Closed

Base: main ← Head: fix-storage-path

📝 Commits (1)

0489f87 fix storage path

📊 Changes

2 files changed (+10 additions, -10 deletions)

View changed files

📝 storage.go (+8 -8)
📝 tests/integration/storage_test.go (+2 -2)

📄 Description

--- FAIL: TestStorage_ISO (0.04s)
    storage_test.go:18: 
        	Error Trace:	storage_test.go:18
        	Error:      	"500 lvm name 'iso/doesnt-exist' contains illegal characters" does not contain "unable to parse directory volume name 'iso/doesnt-exist'"
        	Test:       	TestStorage_ISO

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/luthermonson/go-proxmox/pull/56 **Author:** [@jonasferoz](https://github.com/jonasferoz) **Created:** 3/25/2023 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix-storage-path` --- ### 📝 Commits (1) - [`0489f87`](https://github.com/luthermonson/go-proxmox/commit/0489f87a91b3a2245bc9d5339d8a685ce28acfdf) fix storage path ### 📊 Changes **2 files changed** (+10 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `storage.go` (+8 -8) 📝 `tests/integration/storage_test.go` (+2 -2) </details> ### 📄 Description ``` --- FAIL: TestStorage_ISO (0.04s) storage_test.go:18: Error Trace: storage_test.go:18 Error: "500 lvm name 'iso/doesnt-exist' contains illegal characters" does not contain "unable to parse directory volume name 'iso/doesnt-exist'" Test: TestStorage_ISO ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>