mirror of
https://github.com/devgianlu/go-librespot.git
synced 2026-04-26 05:15:49 +03:00
[GH-ISSUE #15] Volume normalization #8
Labels
No labels
bug
enhancement
pull-request
spotify-side
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/go-librespot#8
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @blamphos on GitHub (Nov 16, 2023).
Original GitHub issue: https://github.com/devgianlu/go-librespot/issues/15
Question to developers, is there volume normalization implemented in go-librespot or is it supported at all? I've noticed that go-librespot produces a bit lower SPL (several dB's) compared to librespot (Rust) implementation which does have a parameter to set the normalization. I've been using external volume control in both cases where ALSA does not use any softvol plugin either.
@devgianlu commented on GitHub (Nov 16, 2023):
The normalisation is implemented here:
github.com/devgianlu/go-librespot@4d530d350e/audio/metadata.go (L184-L192)I have just pushed a change to allow specifying a
normalisation_pregainconfiguration option:github.com/devgianlu/go-librespot@ba47d173f8@blamphos commented on GitHub (Nov 17, 2023):
Did some testing with pulling the latest commits. For some reason I can't change normalisation_pregain from config file. Normalisation factor changes only if the default value of pregain (1.0) is being modified in main.go.
@devgianlu commented on GitHub (Nov 17, 2023):
Oh yeah my bad, should be fixed now.
@blamphos commented on GitHub (Nov 17, 2023):
Thank you! Works just as expected now.