[GH-ISSUE #10] Volume change on devices with big output buffer takes a while #6

New issue

Closed

opened 2026-02-28 14:24:36 +03:00 by kerem · 3 comments

kerem commented

2026-02-28 14:24:36 +03:00

Owner

Originally created by @devgianlu on GitHub (Nov 4, 2023).
Original GitHub issue: https://github.com/devgianlu/go-librespot/issues/10

When changing the volume on devices that have a very long output buffer it takes a while for the effect to propagate because we are outputting multiplied samples. Perphaps there's a way to let the audio backend do the volume? If that's not the case we need to drop the buffer on volume change.

Originally created by @devgianlu on GitHub (Nov 4, 2023). Original GitHub issue: https://github.com/devgianlu/go-librespot/issues/10 When changing the volume on devices that have a very long output buffer it takes a while for the effect to propagate because we are outputting multiplied samples. Perphaps there's a way to let the audio backend do the volume? If that's not the case we need to drop the buffer on volume change.

kerem

2026-02-28 14:24:36 +03:00

closed this issue
added the
bug
label

kerem commented

2026-02-28 14:24:37 +03:00

Author

Owner

@blamphos commented on GitHub (Nov 5, 2023):

First, thanks for awesome work done with this! I understand the reason for multiplying samples but this does not work for setup that is using hardware mixer or external volume control. Could you think of possibility to add config parameter which can be used to disable multiplying samples? Necessary messaging on volume control changes is there already.

@blamphos commented on GitHub (Nov 5, 2023): First, thanks for awesome work done with this! I understand the reason for multiplying samples but this does not work for setup that is using hardware mixer or external volume control. Could you think of possibility to add config parameter which can be used to disable multiplying samples? Necessary messaging on volume control changes is there already.

kerem commented

2026-02-28 14:24:37 +03:00

Author

Owner

@devgianlu commented on GitHub (Nov 5, 2023):

First, thanks for awesome work done with this! I understand the reason for multiplying samples but this does not work for setup that is using hardware mixer or external volume control. Could you think of possibility to add config parameter which can be used to disable multiplying samples? Necessary messaging on volume control changes is there already.

@blamphos I have added a external_volume config option to disable internal handling of volume.

@devgianlu commented on GitHub (Nov 5, 2023): > First, thanks for awesome work done with this! I understand the reason for multiplying samples but this does not work for setup that is using hardware mixer or external volume control. Could you think of possibility to add config parameter which can be used to disable multiplying samples? Necessary messaging on volume control changes is there already. @blamphos I have added a `external_volume` config option to disable internal handling of volume.

kerem commented

2026-02-28 14:24:37 +03:00

Author

Owner

@devgianlu commented on GitHub (May 20, 2024):

See #36

@devgianlu commented on GitHub (May 20, 2024): See #36

kerem referenced this issue

2026-02-28 14:26:04 +03:00

[PR #6] [MERGED] refactor: Separate some app logic into package session #179