[PR #260] [MERGED] Fix normalization #278

New issue

Closed

opened 2026-02-28 14:26:30 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 14:26:30 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/devgianlu/go-librespot/pull/260
Author: @devgianlu
Created: 11/30/2025
Status: ✅ Merged
Merged: 11/30/2025
Merged by: @devgianlu

Base: master ← Head: fix-norm

📝 Commits (3)

d043fec fix: proper normalization according to TruePeak values
d642298 refactor: remove unsued Vorbis metadata normalization
6b7ad33 chore: add normalization details to README

📊 Changes

3 files changed (+42 additions, -25 deletions)

View changed files

📝 README.md (+21 -1)
📝 player/player.go (+21 -3)
📝 vorbis/metadata.go (+0 -21)

📄 Description

Fixes #257.

The main problem with the old logic was that the TruePeak dB value was used as linear. Additionally, we now target Spotify's 14 dB LUFS by default.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/devgianlu/go-librespot/pull/260 **Author:** [@devgianlu](https://github.com/devgianlu) **Created:** 11/30/2025 **Status:** ✅ Merged **Merged:** 11/30/2025 **Merged by:** [@devgianlu](https://github.com/devgianlu) **Base:** `master` ← **Head:** `fix-norm` --- ### 📝 Commits (3) - [`d043fec`](https://github.com/devgianlu/go-librespot/commit/d043fecc26872f04d031ce48bcf2ec709d72acfb) fix: proper normalization according to TruePeak values - [`d642298`](https://github.com/devgianlu/go-librespot/commit/d642298b78c20238cc45cd15d4251a0ec26f294b) refactor: remove unsued Vorbis metadata normalization - [`6b7ad33`](https://github.com/devgianlu/go-librespot/commit/6b7ad331e916312f913ef383c305ea1ff8e85f83) chore: add normalization details to README ### 📊 Changes **3 files changed** (+42 additions, -25 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+21 -1) 📝 `player/player.go` (+21 -3) 📝 `vorbis/metadata.go` (+0 -21) </details> ### 📄 Description Fixes #257. The main problem with the old logic was that the TruePeak dB value was used as linear. Additionally, we now target Spotify's 14 dB LUFS by default. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>