[PR #212] [MERGED] fix: make HttpChunkedReader.ReadAt return io.EOF in case the chunks are finished #247

New issue

Closed

opened 2026-02-28 14:26:24 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 14:26:24 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/devgianlu/go-librespot/pull/212
Author: @tooxo
Created: 9/16/2025
Status: ✅ Merged
Merged: 9/19/2025
Merged by: @devgianlu

Base: master ← Head: patch-1

📝 Commits (1)

331cde3 fix: make HttpChunkedReader.ReadAt return io.EOF in case the chunks are finished.

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 audio/chunked_reader.go (+1 -1)

📄 Description

See: #211

I am also not entirely sure if this is the only code path where it can return illegal values.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/devgianlu/go-librespot/pull/212 **Author:** [@tooxo](https://github.com/tooxo) **Created:** 9/16/2025 **Status:** ✅ Merged **Merged:** 9/19/2025 **Merged by:** [@devgianlu](https://github.com/devgianlu) **Base:** `master` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`331cde3`](https://github.com/devgianlu/go-librespot/commit/331cde3e093499f0c1043130b0a5012f234d7124) fix: make HttpChunkedReader.ReadAt return io.EOF in case the chunks are finished. ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `audio/chunked_reader.go` (+1 -1) </details> ### 📄 Description See: #211 I am also not entirely sure if this is the only code path where it can return illegal values. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>