[PR #197] [MERGED] Mpris integration #244

New issue

Closed

opened 2026-02-28 14:26:23 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 14:26:23 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/devgianlu/go-librespot/pull/197
Author: @tooxo
Created: 8/21/2025
Status: ✅ Merged
Merged: 9/13/2025
Merged by: @devgianlu

Base: master ← Head: mpris

📝 Commits (10+)

2a967a3 feat: add initial poc for mpris integration
8ec0a36 chore: add mpris enabled to config schema
37769f0 fix: stop command, sigsegv in state updates
960e86c chore: do not allow nil in mpris channels
b31a13a refactor: mpris metadata use correct uris
4b76dd4 refactor: improve error handling for mpris
9189ac7 fix: set mpris stopped in the right place
a1b5ce5 chore: align usage of media control methods
e6ffa23 chore: refactor enum
46b6760 chore: add pointer helper method

📊 Changes

10 files changed (+798 additions, -24 deletions)

View changed files

📝 cmd/daemon/controls.go (+64 -0)
📝 cmd/daemon/main.go (+17 -4)
📝 cmd/daemon/player.go (+86 -19)
📝 config_schema.json (+5 -0)
📝 go.mod (+2 -1)
📝 go.sum (+2 -0)
➕ mpris/fallback-server.go (+14 -0)
➕ mpris/interfaces.go (+230 -0)
➕ mpris/model.go (+107 -0)
➕ mpris/server.go (+271 -0)

📄 Description

Todo:

~~locks up on receiving mpris commands with no open session~~
mpris server close is not used yet
~~add logger to mpris package~~

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/devgianlu/go-librespot/pull/197 **Author:** [@tooxo](https://github.com/tooxo) **Created:** 8/21/2025 **Status:** ✅ Merged **Merged:** 9/13/2025 **Merged by:** [@devgianlu](https://github.com/devgianlu) **Base:** `master` ← **Head:** `mpris` --- ### 📝 Commits (10+) - [`2a967a3`](https://github.com/devgianlu/go-librespot/commit/2a967a3d37f7436cb12657699b090acf5dd62115) feat: add initial poc for mpris integration - [`8ec0a36`](https://github.com/devgianlu/go-librespot/commit/8ec0a366272585c27085013700d15668b27b732c) chore: add mpris enabled to config schema - [`37769f0`](https://github.com/devgianlu/go-librespot/commit/37769f05ccd89fb9733bc6e59118a727ae10d838) fix: stop command, sigsegv in state updates - [`960e86c`](https://github.com/devgianlu/go-librespot/commit/960e86cd7f9eb9c5fe085ee627f20f23248a3bae) chore: do not allow nil in mpris channels - [`b31a13a`](https://github.com/devgianlu/go-librespot/commit/b31a13ad9e62292b52f7d267031f2e2294e78ea6) refactor: mpris metadata use correct uris - [`4b76dd4`](https://github.com/devgianlu/go-librespot/commit/4b76dd4e0b969dc85da13dbb836e50a30600633b) refactor: improve error handling for mpris - [`9189ac7`](https://github.com/devgianlu/go-librespot/commit/9189ac7733c3f4c7026078c1cbd15fd6c95e5743) fix: set mpris stopped in the right place - [`a1b5ce5`](https://github.com/devgianlu/go-librespot/commit/a1b5ce5a018f5f8f8dfb2fb3134c0dc7689a2f4d) chore: align usage of media control methods - [`e6ffa23`](https://github.com/devgianlu/go-librespot/commit/e6ffa231a0058a296bc1cda097f5b984ff52e1de) chore: refactor enum - [`46b6760`](https://github.com/devgianlu/go-librespot/commit/46b67601f13958d274ec3521752bca1e710be5c3) chore: add pointer helper method ### 📊 Changes **10 files changed** (+798 additions, -24 deletions) <details> <summary>View changed files</summary> 📝 `cmd/daemon/controls.go` (+64 -0) 📝 `cmd/daemon/main.go` (+17 -4) 📝 `cmd/daemon/player.go` (+86 -19) 📝 `config_schema.json` (+5 -0) 📝 `go.mod` (+2 -1) 📝 `go.sum` (+2 -0) ➕ `mpris/fallback-server.go` (+14 -0) ➕ `mpris/interfaces.go` (+230 -0) ➕ `mpris/model.go` (+107 -0) ➕ `mpris/server.go` (+271 -0) </details> ### 📄 Description Todo: - [x] ~locks up on receiving mpris commands with no open session~ - [ ] mpris server close is not used yet - [x] ~add logger to mpris package~ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>